(🐞) blank-line-with-whitespace (W293) fix is highly unsafe

[KotlinIsland]

def test_something():
    assert foo() == """\
assert [1, 2, 3] == [1, 4, 3]
  
  At index 1 diff: 2 != 4
  Use -v to get more diff"""

Here, the white space on line 2 of the expected value is intentional, yet ruff check --fix deletes it without question.

Or is this actually a bug, and it shouldn't be applying to strings at all?

Workaround

Disable this rule and use ruff format instead, as it doesn't modify the content of strings.

[MichaReiser]

I think that rule shouldn't apply to strings, or if it does, it should be marked as unsafe.

We generally recommend the use of the formatter over style related lint rules if you use the formatter anyway (avoids running unnecessary rules )

[dhruvmanila]

It might be an actual bug because we do mark it as unsafe inside a multiline string:

ruff/crates/ruff_linter/src/rules/pycodestyle/rules/trailing_whitespace.rs

Lines 105 to 113 in 3209b85

	diagnostic.set_fix(Fix::applicable_edit(
	Edit::range_deletion(range),
	// Removing trailing whitespace is not safe inside multiline strings.
	if indexer.multiline_ranges().contains_range(range) {
	Applicability::Unsafe
	} else {
	Applicability::Safe
	},
	));