From 50122d2308840bd085e4abc9552a636b41c3b534 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Mon, 29 Jan 2024 09:33:22 -0800 Subject: [PATCH] [`flake8-pytest-style`] Add fix safety documentation for `duplicate-parameterize-test-cases` (#9678) See: https://github.com/astral-sh/ruff/issues/8482#issuecomment-1859299411. --- .../src/rules/flake8_pytest_style/rules/parametrize.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/ruff_linter/src/rules/flake8_pytest_style/rules/parametrize.rs b/crates/ruff_linter/src/rules/flake8_pytest_style/rules/parametrize.rs index 0f5a621f01eacf..4ff975393b38a5 100644 --- a/crates/ruff_linter/src/rules/flake8_pytest_style/rules/parametrize.rs +++ b/crates/ruff_linter/src/rules/flake8_pytest_style/rules/parametrize.rs @@ -226,6 +226,10 @@ impl Violation for PytestParametrizeValuesWrongType { /// ... /// ``` /// +/// ## Fix safety +/// This rule's fix is marked as unsafe, as tests that rely on mutable global +/// state may be affected by removing duplicate test cases. +/// /// ## References /// - [`pytest` documentation: How to parametrize fixtures and test functions](https://docs.pytest.org/en/latest/how-to/parametrize.html#pytest-mark-parametrize) #[violation]