Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate necessity of HAVE_DYLD_SHARED_CACHE_CONTAINS_PATH on macOS 11 #72

Open
indygreg opened this issue Mar 8, 2021 · 1 comment
Labels
compatibility Compatibility with CPython and the broader ecosystem platform:darwin Specific to the macOS platform

Comments

@indygreg
Copy link
Collaborator

indygreg commented Mar 8, 2021

According to indygreg/PyOxidizer#373 (comment) the HAVE_DYLD_SHARED_CACHE_CONTAINS_PATH feature is required on macOS 11 for things to be happy.

I had unconditionally disabled that feature flag thinking it was an optional feature.

We should probably only conditionally disable on target SDK < 11.0.

But according to @ronaldoussoren it might be required to use ctypes when running on macOS 11?! If so, then the current builds are busted, as Python 3.8 uses the 10.15 SDK and 3.9 - while using the 11.0 SDK - has the feature disabled.

@indygreg
Copy link
Collaborator Author

indygreg commented Mar 8, 2021

I may have spoken too soon: our build only disables this feature on the host CPython builds when cross-compiling. Apparently to workaround some build-time bug. But this shouldn't impact the target builds we distribute.

@charliermarsh charliermarsh added compatibility Compatibility with CPython and the broader ecosystem macos platform:darwin Specific to the macOS platform and removed macos labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility with CPython and the broader ecosystem platform:darwin Specific to the macOS platform
Projects
None yet
Development

No branches or pull requests

2 participants