Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.connect() cannot connect to a TLS endpoint when using IP and not hostname #36

Closed
woopstar opened this issue Dec 13, 2015 · 3 comments

Comments

@woopstar
Copy link

Trying to connect to an Asterisk server using HTTPS because the asterisk http server is running TLS does not work, if you do not use a hostname with certificate.

Maybe an option to allow it to connect but not validate the certificate when you use the ip to connect directly?

@samuelg
Copy link
Contributor

samuelg commented Dec 15, 2015

I will have to research this further. If the issue is on the node-ari-client side I expect we'll have to push this upstream as we are dependent on swagger-js to connect to ARI. If the issue has to do with Asterisk itself then https://issues.asterisk.org would be the correct place to get this resolved.

@samuelg
Copy link
Contributor

samuelg commented Dec 15, 2015

Looks like swagger-api/swagger-js#229 would allow us to skip the cert check in the underlying http client. I'll see if I can find some time to work on this in the coming weeks. In the mean time, contributions are welcome.

@FrancescoMasaia
Copy link

FrancescoMasaia commented Oct 17, 2023

@woopstar How did you managed to use TLS with current version of this library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants