Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push a new version to CRAN? #153

Closed
bbolker opened this issue Apr 27, 2024 · 11 comments
Closed

push a new version to CRAN? #153

bbolker opened this issue Apr 27, 2024 · 11 comments

Comments

@bbolker
Copy link

bbolker commented Apr 27, 2024

The version on CRAN is two years old, and there are useful things in the development version. (I'm particularly interested in the switch to tinytest and corresponding decrease in upstream dependencies ...)

I haven't tried running R CMD check, but if you do encounter any submission-related issues, I would be happy to help troubleshoot.

@aadler
Copy link
Contributor

aadler commented Apr 28, 2024

Hi, @bbolker. For my contributions (mainly unit tests but some error fixes and efficiency tweaks), the package passed -as-CRAN. I'm pretty sure it did for @eddelbuettel as well, but it's up to @astamm to decide :).

@astamm
Copy link
Owner

astamm commented Apr 28, 2024

Hi guys. Thanks for the reminder. I am on it.

@aadler
Copy link
Contributor

aadler commented May 23, 2024

Cough, cough, nudge, poke, wink, smile, cough…

@bbolker
Copy link
Author

bbolker commented Jun 4, 2024

Still hoping for this (although I certainly have my own problems to deal with as well)

@aadler
Copy link
Contributor

aadler commented Jun 4, 2024

@astamm, what could we do to help you prepare for a new release? Is there anything outstanding in your mind or is it simply a matter of time?

@aadler
Copy link
Contributor

aadler commented Jun 5, 2024

Hi, @bbolker. I just sent PR #157 to @astamm, which addresses three outstanding issues. I do have the idea to finish cleaning up the examples and adding some more unit tests for accuracy (based on those examples), but I am not sure if that's worth holding up a new CRAN release, being that it has been so long. See what's under 2.1.0 in the PR for just how much has changed!

@aadler
Copy link
Contributor

aadler commented Jun 14, 2024

@astamm, pushing the new version to CRAN to remove testthat will help with many other issues as well, since testthat imports a good chunk of the tidyverse and that's causing problems in other places, like lme4.

@astamm
Copy link
Owner

astamm commented Jun 14, 2024

I apologise for the limited bandwidth. I will submit a new release to CRAN next week.

@astamm
Copy link
Owner

astamm commented Jun 19, 2024

On its way to CRAN as of today.

@astamm astamm closed this as completed Jun 19, 2024
@aadler
Copy link
Contributor

aadler commented Jun 19, 2024

97.53% coverage, so beautiful!

@astamm
Copy link
Owner

astamm commented Jun 19, 2024

Thanks to you @aadler !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants