Skip to content
This repository was archived by the owner on Dec 16, 2023. It is now read-only.

Replay Needs Reset or Cleanup Function #159

Open
ggb667 opened this issue Nov 12, 2018 · 1 comment
Open

Replay Needs Reset or Cleanup Function #159

ggb667 opened this issue Nov 12, 2018 · 1 comment

Comments

@ggb667
Copy link

ggb667 commented Nov 12, 2018

Replay needs a cleanup function.

I tried this at the start of index.js (for use in a before block in a mocha test):

const HTTP = require('http');
const HTTPS = require('https');
const DNS = require('dns');
const origHttpRequest = HTTP.request;
const origHttpGet = HTTP.get;
const origHttpsGet = HTTPS.get;
const originalLookup = DNS.lookup;

restore() {
HTTP.request = origHttpRequest;
HTTP.get = origHttpGet;
HTTPS.get = origHttpsGet;
DNS.lookup = originalLookup;
}

But I missed something because this still has problems when people use nock or sinon, and we would need something for the before block to undo this.

@ggb667
Copy link
Author

ggb667 commented Nov 12, 2018

What I ended up doing for now in each test:

before(function(){
if(process.env.REPLAY) {
Replay.mode = process.env.REPLAY;
}
});

after(function(){
Replay.mode = "bloody";
});

@ggb667 ggb667 closed this as completed Nov 12, 2018
@ggb667 ggb667 reopened this Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant