Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Fix warnings in the build #381

Closed
davidfowl opened this issue Jun 25, 2014 · 5 comments
Closed

Fix warnings in the build #381

davidfowl opened this issue Jun 25, 2014 · 5 comments
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

@ChengTian We should also turn on warnings as errors once this is fixed.

@ChengTian
Copy link
Contributor

@davidfowl I tested kpm build and seems it can generate correct warnings. Which specific part needs to be fixed?

@davidfowl
Copy link
Member Author

Not that our build has warnings :). Building KRuntime shows warnings which is bad. We need to fix them

@ChengTian
Copy link
Contributor

I see: ) I will be working on them.

@ChengTian
Copy link
Contributor

@davidfowl , XmlUtility class defined in
Microsoft.Framework.PackageManager / NuGet / Core / Utility / XmlUtility.cs
conflicts with the one defined in
Microsoft.Framework.Runtime / NuGet / Utility / XmlUtility.cs
The two files have almost identical contents. Do we want to move XmlUtility.cs to a common project which can be shared across all projects?

@davidfowl
Copy link
Member Author

Keep it in the runtime and nuke the one in PackageManager

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants