Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Mono's net45 is really net451 #374

Closed
borgdylan opened this issue Jun 24, 2014 · 6 comments
Closed

Mono's net45 is really net451 #374

borgdylan opened this issue Jun 24, 2014 · 6 comments
Assignees
@davidfowl
Labels
3 - Done bug
Milestone
1.0.0-alpha4

Comments

@borgdylan
Copy link

Regarding the code in https://github.com/aspnet/KRuntime/blob/dev/src/Microsoft.Framework.Runtime/FrameworkReferenceResolver.cs#L90 , mono support is hard coded to net40 and net45 only. According to Marek Safar from the Mono team, their .net 4.5 profile is approaching .net 4.5.1 compatibility and for them the two framework profiles are equal. i.e. for mono while resolving whether net451 is available is the same as checking for net45.
@bricelam bricelam mentioned this issue Jun 24, 2014
Closed
@davidfowl davidfowl self-assigned this Jul 23, 2014
@davidfowl davidfowl added this to the 1.0.0-alpha3 milestone Jul 23, 2014
@davidfowl davidfowl modified the milestones: 1.0.0-alpha3, 1.0.0-alpha4 Aug 6, 2014
davidfowl added a commit that referenced this issue Aug 19, 2014
@davidfowl
Make mono run as .NET 4.5.1
c41543b 
- Turns out mono's 4.5 profile (for the versions of mono we support)
is actually compatible with .NET 4.5.1.
- Fix problem with compiling against reference assemblies
that were not resolved via dependency resolution.

#511
#374
@davidfowl davidfowl mentioned this issue Aug 19, 2014
Merged
davidfowl added a commit that referenced this issue Aug 19, 2014
@davidfowl
Make mono run as .NET 4.5.1
19d7d2e 
- Turns out mono's 4.5 profile (for the versions of mono we support)
is actually compatible with .NET 4.5.1.
- Fix problem with compiling against reference assemblies
that were not resolved via dependency resolution.

#511
#374
@Praburaj
Copy link
Contributor

Nice. I will try things on Mono.

@Praburaj
Copy link
Contributor

This fix seems to work. I can see the entire music store sample working fine on mono without any hacks. Except for this bug aspnet/Mvc#916 I can see the sample pretty much working on mono.

@desdesdes
Copy link

Shouldn't 4.5.2 and 4.5.3 also run against the 4.5 folder in mono?

@davidfowl
Copy link
Member

Who knows, we'll fix it when something breaks. There's no consistent way to do this on mono proper anyways.

@Praburaj
Copy link
Contributor

Praburaj commented Oct 3, 2014

Looks like with beta bits, EF Sql server package is running into this issue again. Reopening the bug @suhasj

We used KRE# beta1-10491 and tested against both 3.6.1 and 3.8.0 of mono.

@Praburaj Praburaj reopened this Oct 3, 2014
@Praburaj Praburaj mentioned this issue Oct 3, 2014
Closed
@Praburaj
Copy link
Contributor

Praburaj commented Oct 3, 2014

Opened a different bug #690
Closing this down.

@Praburaj Praburaj closed this as completed Oct 3, 2014
@walro walro mentioned this issue May 26, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-alpha4
Development

No branches or pull requests
4 participants
@davidfowl @desdesdes @Praburaj @borgdylan