-
Notifications
You must be signed in to change notification settings - Fork 224
Command names in project.json are case sensistive #158
Comments
Why shouldn't it be? |
We almost never do case-sensitive for keys. Look at routing, config, controller names, file names, etc. I see no reason to have this be case sensitive. |
I'm not sure I agree, yes other things aren't case insensitive but this seems different. This ain't VB 😄 |
why would we want to allow a bunch of Run run RuN RUN commands which all do different things? |
Typing with an incorrect case is a common mistake most people do. We should avoid throwing. |
Sorry I just don't agree and I think its broken |
I'm not sure I know of any key value that we use that's case sensitive aside from this... do we have examples where we've previously used case-sensitive dictionaries for stuff that a developer accesses? |
I think this wild ordinal ignore case we do makes sense in alot of places and it will start to hurt when we try to get things running cross platform. I can understand why we'd want to make this case insensitive but I agree with @HaoK. There's never a case where you'd want different commands with different casing. Our error messages suck right now, is that why this is causing such a big problem? |
I think one way to solve some of the cross-platform issues you're probably thinking of is to normalize strings - e.g. always call The error today definitely could use some improvement - that could very well be a temporary mitigation and we can evaluate the case sensitivity issue separately. |
It'll work for most things and will fail whenever we access the file system. |
Yup I get that. We might end up having to make a distinction as to when a key is strictly "in" the system as opposed to a key that leaks back out to the OS/environment. |
This is fixed |
In my project.json I have:
If I run
Everything works fine.
However, if I run
(notice the capital W) I get:
The text was updated successfully, but these errors were encountered: