Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

PathString should have a registered TypeConverter #848

Closed
MarkPflug opened this issue May 24, 2017 · 2 comments
Closed

PathString should have a registered TypeConverter #848

MarkPflug opened this issue May 24, 2017 · 2 comments
Assignees
@HaoK
Labels
3 - Done enhancement
Milestone
2.0.0

Comments

@MarkPflug
Copy link

I ran into an issue while attempting to configure the OpenIdConnect provider using the Options/configuration APIs. The issue was around trying to assign a the OpenIdConnect.CallbackPath value which is of type PathString. This failed, with a conversion error trying to convert my string value from the configuration to the PathString property.
The original issue is here: aspnet/Security#1230

This can resolved by reigistering a TypeConverter for PathString. However, it seems like such a TypeConverter would be best defined along side the PathString class itself.
@Tratcher Tratcher mentioned this issue Jun 1, 2017
Merged
@HaoK HaoK self-assigned this Jun 5, 2017
@HaoK
Copy link
Member

HaoK commented Jun 5, 2017

Added for preview 2, but I need to harden the implementation + add a few more tests, so keeping this on my plate for now

@HaoK HaoK added this to the 2.0.0 milestone Jun 5, 2017
@HaoK HaoK mentioned this issue Jun 15, 2017
Closed
@HaoK HaoK added 3 - Done and removed 2 - Working labels Jun 20, 2017
@HaoK
Copy link
Member

HaoK commented Jun 20, 2017

12f89f6

@HaoK HaoK closed this as completed Jun 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@HaoK @MarkPflug