Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SaveChanges circular dependency exception #8363

Closed
AndriySvyryd opened this issue May 2, 2017 · 0 comments
Closed

Improve SaveChanges circular dependency exception #8363

AndriySvyryd opened this issue May 2, 2017 · 0 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. punted-for-2.0 type-enhancement
Milestone
2.1.0

Comments

@AndriySvyryd
Copy link
Member

If sensitive data logging is enabled the exception should provide the key values involved in the cycle
@ajcvickers ajcvickers added this to the 2.0.0 milestone May 5, 2017
@ajcvickers ajcvickers modified the milestones: Backlog, 2.0.0 May 5, 2017
@ajcvickers ajcvickers added help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. and removed consider-for-current-release labels Sep 7, 2017
@ajcvickers ajcvickers modified the milestones: 2.1.0, Backlog Sep 7, 2017
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview1, 2.1.0 Jan 17, 2018
AndriySvyryd added a commit that referenced this issue Feb 6, 2018
@AndriySvyryd
Improve SaveChanges circular dependency message
a3cfd3a 
Update transient error message
Add sensitive data to the conceptual null exception
Don't validate mapping for shadow properties created by convention
Improve incompatible principal entity during fixup exception
Correct property is already a navigation exception

Fixes #8363
Fixes #8365
Fixes #9696
Fixes #9817
Fixes #10135
Fixes #10856
@AndriySvyryd AndriySvyryd mentioned this issue Feb 6, 2018
Merged
AndriySvyryd added a commit that referenced this issue Feb 6, 2018
@AndriySvyryd
Improve SaveChanges circular dependency message
5d0dc23 
Update transient error message
Add sensitive data to the conceptual null exception
Don't validate mapping for shadow properties created by convention
Improve incompatible principal entity during fixup exception
Correct property is already a navigation exception

Fixes #8363
Fixes #8365
Fixes #9696
Fixes #9817
Fixes #10135
Fixes #10856
AndriySvyryd added a commit that referenced this issue Feb 6, 2018
@AndriySvyryd
Improve SaveChanges circular dependency message
779d0ef 
Update transient error message
Add sensitive data to the conceptual null exception
Don't validate mapping for shadow properties created by convention
Improve incompatible principal entity during fixup exception
Correct property is already a navigation exception

Fixes #8363
Fixes #8365
Fixes #9696
Fixes #9817
Fixes #10135
Fixes #10856
@AndriySvyryd AndriySvyryd removed their assignment Feb 6, 2018
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 6, 2018
@bricelam bricelam added good first issue This issue should be relatively straightforward to fix. and removed good first issue This issue should be relatively straightforward to fix. labels May 31, 2019
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. good first issue This issue should be relatively straightforward to fix. help wanted This issue involves technologies where we are not experts. Expert help would be appreciated. punted-for-2.0 type-enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@bricelam @ajcvickers @AndriySvyryd