-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model configuration: Set ValueGenerated for store-generated properties using a convention #7205
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Milestone
Comments
We should consider looking at other fluent APIs that do multiple things and can switch to using conventions. We should also evaluate if the complexity increase is worth the functional improvement we expect (in this case, mainly it is that setting the value in metadata APIs will have the same observable effect as doing it on the fluent API). |
More learning, mutual guidance |
AndriySvyryd
added a commit
that referenced
this issue
Dec 22, 2016
AndriySvyryd
added a commit
that referenced
this issue
Dec 22, 2016
AndriySvyryd
added a commit
that referenced
this issue
Apr 13, 2017
AndriySvyryd
added a commit
that referenced
this issue
Apr 14, 2017
AndriySvyryd
added a commit
that referenced
this issue
Apr 14, 2017
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Apr 19, 2019
Reacting to dotnet/efcore#7205 Note that this was done a long time ago in EFCore (2.0.0) but only now discovered thanks to the internal analyzer warnings.
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Apr 19, 2019
Reacting to dotnet/efcore#7205 Note that this was done a long time ago in EFCore (2.0.0) but only now discovered thanks to the internal analyzer warnings.
roji
added a commit
to roji/efcore.pg
that referenced
this issue
Apr 20, 2019
Reacting to dotnet/efcore#7205 Note that this was done a long time ago in EFCore (2.0.0) but only now discovered thanks to the internal analyzer warnings.
roji
added a commit
to npgsql/efcore.pg
that referenced
this issue
Apr 21, 2019
Reacting to dotnet/efcore#7205 Note that this was done a long time ago in EFCore (2.0.0) but only now discovered thanks to the internal analyzer warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
closed-fixed
The issue has been fixed and is/will be included in the release indicated by the issue milestone.
type-enhancement
Currently setting
DefaultValue
,DefaultValueSql
,ComputedColumnSql
orSqlServer().ValueGenerationStrategy
setsValueGenerated
in the Fluent API usingConfigurationSource.Convention
.This means that
ValueGenerated
is not updated when the mentioned facets are set using the Metadata API.Also it might get out of date when merging the property facets since it doesn't use the same ConfigurationSource:
If
DefaultValue
is set by convention on base type, butComputedColumnSql
is set explicitly on base. When the base type is set the property will haveComputedColumnSql
configured, but it could still haveValueGenerated
set toOnAdd
The text was updated successfully, but these errors were encountered: