diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1e8224579..0e008b00b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -15,18 +15,14 @@ jobs: - name: Checkout uses: actions/checkout@v2 - uses: bazelbuild/setup-bazelisk@v1 - - name: check git state is clean - run: git status --porcelain - name: bazel test //... env: # Bazelisk will download bazel to here XDG_CACHE_HOME: ~/.cache/bazel-repo run: - bazel --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test - --config=release //... + bazel --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //... - name: Release uses: softprops/action-gh-release@v1 with: prerelease: true - files: | - bazel-out/*/bin/path/to/some/output + files: bazel-out/*/bin/*.tar.gz diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 665d49b03..b1519649c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,3 +36,11 @@ echo "query $OVERRIDE" >> ~/.bazelrc ``` This means that any usage of `@rules_js` on your system will point to this folder. + +## Releasing + +1. Update the constant in `version.bzl` +1. `git tag v$(grep VERSION version.bzl | cut -d'"' -f2)` +1. git push --tags +1. Watch the automation run on GitHub actions +1. Update the release page with auto-generated release notes diff --git a/README.md b/README.md index 3a1e272e4..3f290c1ad 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,7 @@ http_archive( sha256 = "", ) -load("@aspect_rules_js//js:repositories.bzl", "js_rules_dependencies") +load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies") # This fetches the aspect_rules_js dependencies, which are: # - bazel_skylib diff --git a/js/private/nodejs_binary.bzl b/js/private/nodejs_binary.bzl index a163a9425..483bf45dd 100644 --- a/js/private/nodejs_binary.bzl +++ b/js/private/nodejs_binary.bzl @@ -106,7 +106,7 @@ def _bash_launcher(ctx, linkable): {rlocation_function} set -o pipefail -o errexit -o nounset {node_path} -NODE_DEBUG=module $(rlocation {node}) \\ +$(rlocation {node}) \\ $(rlocation {entry_point}) \\ {args} $@ """.format(