Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds correct UI tests for SoundLibraryFragment and AboutFragment #4

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

ashutoshgngwr
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #4 into master will increase coverage by 7.24%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #4      +/-   ##
============================================
+ Coverage     84.93%   92.18%   +7.24%     
- Complexity      111      120       +9     
============================================
  Files             7        7              
  Lines           644      640       -4     
  Branches         80       73       -7     
============================================
+ Hits            547      590      +43     
+ Misses           57       12      -45     
+ Partials         40       38       -2
Impacted Files Coverage Δ Complexity Δ
...hutoshgngwr/noice/fragment/SoundLibraryFragment.kt 87.17% <94.73%> (+34.28%) 13 <1> (+7) ⬆️
...m/github/ashutoshgngwr/noice/MediaPlayerService.kt 93.44% <0%> (+0.81%) 28% <0%> (+1%) ⬆️
...ava/com/github/ashutoshgngwr/noice/SoundManager.kt 98.34% <0%> (+0.82%) 50% <0%> (+1%) ⬆️
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 98.31% <0%> (+2.52%) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17d079...4f225c7. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit b4d8040 into master Jun 18, 2019
@ashutoshgngwr ashutoshgngwr added the tests Pull requests that update test cases label Jun 18, 2019
@ashutoshgngwr ashutoshgngwr deleted the test/ui branch June 18, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant