Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken parcel builds #249

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Fixes broken parcel builds #249

merged 2 commits into from
Jul 25, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

  • Fixes broken parcel builds

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

  • Fixes #0
  • Connects #0

@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #249 into master will decrease coverage by 11.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #249       +/-   ##
===========================================
- Coverage   97.79%   86.57%   -11.22%     
===========================================
  Files           3       29       +26     
  Lines         136     1408     +1272     
  Branches       30      177      +147     
===========================================
+ Hits          133     1219     +1086     
- Misses          3       92       +89     
- Partials        0       97       +97     
Flag Coverage Δ
#android 85.37% <ø> (?)
#cast_receiver 97.79% <ø> (ø)
#ui_tests 63.14% <ø> (?)
#unit_tests 45.79% <ø> (-52.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ub/ashutoshgngwr/noice/cast/CastOptionsProvider.kt 85.71% <0.00%> (ø)
...hub/ashutoshgngwr/noice/widget/MarkdownTextView.kt 44.44% <0.00%> (ø)
...ice/sound/player/strategy/LocalPlaybackStrategy.kt 92.15% <0.00%> (ø)
.../github/ashutoshgngwr/noice/sound/player/Player.kt 92.10% <0.00%> (ø)
...ashutoshgngwr/noice/fragment/SleepTimerFragment.kt 95.00% <0.00%> (ø)
...toshgngwr/noice/cast/CastSessionManagerListener.kt 10.00% <0.00%> (ø)
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 98.63% <0.00%> (ø)
...shutoshgngwr/noice/fragment/WakeUpTimerFragment.kt 84.61% <0.00%> (ø)
...hub/ashutoshgngwr/noice/cast/CastVolumeProvider.kt 85.71% <0.00%> (ø)
...m/github/ashutoshgngwr/noice/WakeUpTimerManager.kt 75.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aec0d77...01f22f4. Read the comment docs.

@ashutoshgngwr ashutoshgngwr changed the title Reverts @babel/preset-env version bump Fixes broken parcel builds Jul 25, 2020
@ashutoshgngwr ashutoshgngwr merged commit ff0f744 into master Jul 25, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/cast-receiver/build branch July 25, 2020 07:41
@ashutoshgngwr ashutoshgngwr added this to the 0.9.x milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant