Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates to using vector drawables #176

Merged
merged 1 commit into from
May 23, 2020
Merged

Migrates to using vector drawables #176

merged 1 commit into from
May 23, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

  • Add single density vector drawables
  • Remove multi density PNG drawables

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

  • Fixes #0
  • Connects #0

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #176 into 0.7.x will not change coverage.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##              0.7.x     #176   +/-   ##
=========================================
  Coverage     82.05%   82.05%           
  Complexity      134      134           
=========================================
  Files            12       12           
  Lines           847      847           
  Branches         83       83           
=========================================
  Hits            695      695           
  Misses           91       91           
  Partials         61       61           
Impacted Files Coverage Δ Complexity Δ
...m/github/ashutoshgngwr/noice/MediaPlayerService.kt 29.72% <0.00%> (ø) 5.00 <0.00> (ø)
...thub/ashutoshgngwr/noice/fragment/AboutFragment.kt 99.28% <100.00%> (ø) 6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fa6198...fc93b16. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit 17a691b into 0.7.x May 23, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/icons branch May 23, 2020 11:26
@ashutoshgngwr ashutoshgngwr added this to the 0.7.x milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant