Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates Material design from AppCompat to MaterialComponents #141

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

  • Use the new material components library
  • Fix a minor issue with navigation view

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

  • Fixes N/A
  • Connects N/A

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #141 into master will decrease coverage by 0.27%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
- Coverage     78.63%   78.35%   -0.28%     
  Complexity      107      107              
============================================
  Files            11       11              
  Lines           730      730              
  Branches         85       86       +1     
============================================
- Hits            574      572       -2     
- Misses           88       89       +1     
- Partials         68       69       +1     
Impacted Files Coverage Δ Complexity Δ
...hutoshgngwr/noice/fragment/SoundLibraryFragment.kt 80.48% <ø> (-0.24%) 8.00 <0.00> (ø)
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 80.68% <33.33%> (-1.88%) 17.00 <0.00> (ø)
...hub/ashutoshgngwr/noice/fragment/PresetFragment.kt 88.54% <100.00%> (-0.12%) 5.00 <0.00> (ø)
...shgngwr/noice/fragment/SavePresetDialogFragment.kt 70.00% <100.00%> (ø) 4.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 724accd...c73ac61. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit 52f204e into master Apr 23, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/appearance branch April 23, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant