Add german strings and credits #138
Conversation
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
============================================
+ Coverage 78.51% 78.63% +0.11%
Complexity 107 107
============================================
Files 11 11
Lines 726 730 +4
Branches 85 85
============================================
+ Hits 570 574 +4
Misses 88 88
Partials 68 68
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi Steffen,
Thank you for taking the time to submit the translations. Can you please remove all the strings attributed with translatable="false" from values-de/strings.xml. Everything else looks good. I'll pull this in once these strings are removed.
Also, if you'd like to add metadata translations, just copy hi-IN directory as de-DE and fill in all the files that are present in the directory (translating from the en-US version). You don't need any test setup, let me worry about that. If you do decide to add metadata translations, please include screenshots as well.
| <string name="app_website" translatable="false">https://ashutoshgngwr.github.io/noice</string> | ||
| <string name="app_playstore" translatable="false">com.github.ashutoshgngwr.noice</string> | ||
| <string name="app_github" translatable="false">ashutoshgngwr/noice</string> | ||
| <string name="connect_with_author">Autor kontaktieren</string> |
There was a problem hiding this comment.
I think you deleted 49th line by mistake.
|
Sorry, seems this is not may day 😀 Hope it is correct now. Regarding playstore metadata, I currently cannot use Android Studio to build my localiced version in order to provide screenshots. I'm a blind user, and The software is partly inaccessible to the screen reader software which I'm using. So I'm doing the translation by hand. |
|
@schulle4u This looks good. I'd really appreciate if you can add just the translations for the metadata. I can add screenshots myself. Totally upto you, just let me know. |
|
OK thanks. Give me some minutes, I'm on my way. |
There was a problem hiding this comment.
Thanks @schulle4u
It needs some changes but I'll take it from here.
Changes
This adds german string ressources and translator credits. Unfortunately no metadata at this time, as I don't have a sufficient development/testing environment.
Connects #108