Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds white, pink and brownian noise to the sound library #125

Merged
merged 3 commits into from
Apr 11, 2020

Conversation

ashutoshgngwr
Copy link
Member

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

  • Fixes #0
  • Connects #0

@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #125 into master will increase coverage by 0.39%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
+ Coverage     77.99%   78.39%   +0.39%     
- Complexity      107      110       +3     
============================================
  Files            11       11              
  Lines           709      722      +13     
  Branches         85       89       +4     
============================================
+ Hits            553      566      +13     
+ Misses           88       86       -2     
- Partials         68       70       +2     
Impacted Files Coverage Δ Complexity Δ
...java/com/github/ashutoshgngwr/noice/sound/Sound.kt 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...shgngwr/noice/fragment/SavePresetDialogFragment.kt 77.77% <0.00%> (+13.07%) 7.00% <0.00%> (+3.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2506fe...20fdb4d. Read the comment docs.

@ashutoshgngwr ashutoshgngwr added the enhancement New feature or request label Apr 11, 2020
@ashutoshgngwr ashutoshgngwr merged commit 2e9e310 into master Apr 11, 2020
@ashutoshgngwr ashutoshgngwr deleted the feat/actual-noises branch April 11, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant