Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes force close caused by the JSON deserialization after upgrading from 0.2.7 or older #117

Merged
merged 2 commits into from
Mar 29, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

  • Added missing proguard rules for Gson library
  • Explicitly specify field names to use for serialization/deserialization from older versions

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #117 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     77.45%   77.51%   +0.06%     
  Complexity      102      102              
============================================
  Files            11       11              
  Lines           683      685       +2     
  Branches         83       83              
============================================
+ Hits            529      531       +2     
  Misses           88       88              
  Partials         66       66              
Impacted Files Coverage Δ Complexity Δ
...a/com/github/ashutoshgngwr/noice/sound/Playback.kt 75.00% <ø> (ø) 18.00 <0.00> (ø)
...hub/ashutoshgngwr/noice/fragment/PresetFragment.kt 88.65% <100.00%> (+0.23%) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f00629f...4b34687. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash when viewing Saved Presets after upgrading 0.2.7 -> 0.3.x
1 participant