Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes volume serialization/deserialization to/from JSON in Playback #105

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

ashutoshgngwr
Copy link
Member

This was breaking compatibility after 0.3.0. Older versions used a Float data type for volumes while newer versions started using Int. This was an oversight and hence the fix.

Changes

Add a custom Serializer and Deserializer for volume field in playback

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

  • Fixes #0
  • Connects #0

was breaking compatibility after 0.3.0. Older versions used a Float
data type for volumes while newer versions started using Int. This
was an oversight and hence the fix.
@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #105 into master will decrease coverage by 0.34%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #105      +/-   ##
============================================
- Coverage     77.72%   77.38%   -0.35%     
  Complexity      102      102              
============================================
  Files            11       11              
  Lines           669      681      +12     
  Branches         81       83       +2     
============================================
+ Hits            520      527       +7     
- Misses           85       88       +3     
- Partials         64       66       +2     
Impacted Files Coverage Δ Complexity Δ
...a/com/github/ashutoshgngwr/noice/sound/Playback.kt 75.00% <37.50%> (-5.77%) 18.00 <0.00> (ø)
...hutoshgngwr/noice/fragment/SoundLibraryFragment.kt 80.72% <0.00%> (+0.23%) 8.00% <0.00%> (ø%)
...ithub/ashutoshgngwr/noice/sound/PlaybackManager.kt 75.23% <0.00%> (+0.23%) 26.00% <0.00%> (ø%)
...hub/ashutoshgngwr/noice/fragment/PresetFragment.kt 88.42% <0.00%> (+0.24%) 5.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3faaaaf...e7538b2. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit 1aea2b1 into master Mar 23, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/playback-volume-deserialization branch March 23, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant