Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parking lot example only parks cars #27

Closed
nakshay opened this issue Aug 25, 2024 · 2 comments
Closed

Parking lot example only parks cars #27

nakshay opened this issue Aug 25, 2024 · 2 comments

Comments

@nakshay
Copy link
Contributor

nakshay commented Aug 25, 2024

I am no sure if this is expected or not but the parking lot solution always accepts only CARs to be parked as the parking lot class has a default type as CAR, hence truk and bike is never parked and hence after bike is unparked there is no change in the output before and after.

possible solutions:

  1. Assigned fixed number of parking for different kind of vehicles on each level.
  2. Assign random type of vehicles for parking lot on each level
  3. Have some ratios

If you agree on one of the solution I can fix and raise the PR.

@nakshay
Copy link
Contributor Author

nakshay commented Aug 26, 2024

Have created a PR for the same, divides slots in ratio of 50:40:10

@ashishps1
Copy link
Owner

Hey, thanks for creating the PR. I have merged it. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants