Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json engines #235

Closed
david-luna opened this issue Jul 24, 2023 · 2 comments · Fixed by #236
Closed

Update package.json engines #235

david-luna opened this issue Jul 24, 2023 · 2 comments · Fixed by #236

Comments

@david-luna
Copy link

Hi,

Latest release 2.1.0 added support for lambda streaming which is pretty neat :)

I see the package.json file declares it supports node >=6 in the engines section. But on the streaming related files the package is using globalThis symbol here.

This symbol is available from version 12.4.0 according to node.green so I guess engines should be updated. I'm wondering if there is a way to make it still work in node 6.

Thanks

@gpotter2
Copy link
Collaborator

gpotter2 commented Jul 24, 2023

Thanks for the report !
Arguably, we should probably drop support for anything <= 8, as it is starting to be seriously out of date. But I'll have a look at how we can maximize support.

What do you think of #236 ?

@david-luna
Copy link
Author

Hi @gpotter2,

Sorry for the late reply. The change looks neat and stills support a wide version range :)

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants