Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with pcre2 #40

Closed
Vascom opened this issue Dec 6, 2022 · 5 comments
Closed

Build with pcre2 #40

Vascom opened this issue Dec 6, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request fixed The issue has been fixed

Comments

@Vascom
Copy link

Vascom commented Dec 6, 2022

Could you plead add support for build gsmartcontrol with pcre2.
Old pcre is deprecated at Fedora Linux so I need rebuild with pcre2.

https://fedoraproject.org/wiki/PcreDeprecation
https://bugzilla.redhat.com/show_bug.cgi?id=2128306

@ashaduri
Copy link
Owner

ashaduri commented Dec 7, 2022

GSmartControl currently depends on pcrecpp, which is a part of pcre, but not pcre2.
There are two options to handle this:

  • Port pcrecpp to pcre2 (not sure about this). This may be the easy way.
  • Port GSmartControl to C++ regex. This will require some very good tests as C++ implementations vary quite a lot.

Most of the pcrecpp code in GSmartControl will also lose much of its usefulness once the JSON support is fully implemented.

Anyway, since Fedora does seem to be giving the developers plenty of time for migration, I will be continuing the main branch development and porting the non-JSON parser to C++. If a time comes that the pcre1 support is removed from Fedora and the C++ support is not done yet, I'll look into porting pcrecpp to pcre2.

Thanks
🇺🇦

@ashaduri ashaduri added the enhancement New feature or request label Dec 7, 2022
@Vascom
Copy link
Author

Vascom commented Dec 7, 2022

Thanks.

@skitt
Copy link
Contributor

skitt commented Mar 19, 2023

See also https://bugs.debian.org/1000074 (for Debian).

@dvzrv
Copy link

dvzrv commented Apr 17, 2024

Hi! 👋

On Arch Linux we have also started the process to replace pcre with pcre2 as the former is now unmaintained:
https://archlinux.org/todo/move-to-pcre2/

Removing the need for pcre would therefore be much appreciated 🙏

@ashaduri
Copy link
Owner

The program has been ported to std::regex (needs testing).
The main branch no longer depends on PCRE.

@ashaduri ashaduri added the fixed The issue has been fixed label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed The issue has been fixed
Projects
None yet
Development

No branches or pull requests

4 participants