From f4b4932f824e780b636ef6d7c0a2f033941ecb9b Mon Sep 17 00:00:00 2001 From: cinnamoroll6130 Date: Thu, 19 Sep 2024 20:28:52 -0400 Subject: [PATCH 1/7] update locales for asset select modal --- src/renderer/i18n/de/common.ts | 1 + src/renderer/i18n/en/common.ts | 1 + src/renderer/i18n/es/common.ts | 3 ++- src/renderer/i18n/fr/common.ts | 1 + src/renderer/i18n/hi/common.ts | 1 + src/renderer/i18n/ru/common.ts | 1 + src/renderer/i18n/types.ts | 1 + 7 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/renderer/i18n/de/common.ts b/src/renderer/i18n/de/common.ts index af32895dc..1ab15c5cb 100644 --- a/src/renderer/i18n/de/common.ts +++ b/src/renderer/i18n/de/common.ts @@ -147,6 +147,7 @@ const common: CommonMessages = { 'common.asset.base': 'Basis', 'common.asset.change': 'Ändere Asset', 'common.asset.quickSelect': 'Schnellauswahl L1', + 'common.asset.chooseAsset': 'Wählen Sie ein Asset', 'common.noResult': 'Kein Ergebnis', 'common.rate': 'Rate', 'common.tx.type.swap': 'Swap', diff --git a/src/renderer/i18n/en/common.ts b/src/renderer/i18n/en/common.ts index cf95e676c..254a9dab8 100644 --- a/src/renderer/i18n/en/common.ts +++ b/src/renderer/i18n/en/common.ts @@ -146,6 +146,7 @@ const common: CommonMessages = { 'common.asset.base': 'Base', 'common.asset.change': 'Change asset', 'common.asset.quickSelect': 'Quick Select L1', + 'common.asset.chooseAsset': 'Choose an asset', 'common.noResult': 'No result', 'common.rate': 'Rate', 'common.tx.type.swap': 'Swap', diff --git a/src/renderer/i18n/es/common.ts b/src/renderer/i18n/es/common.ts index b4e5533bd..f094fcb5e 100644 --- a/src/renderer/i18n/es/common.ts +++ b/src/renderer/i18n/es/common.ts @@ -193,7 +193,8 @@ const common: CommonMessages = { 'common.expandAll': 'Expandir todo', 'common.excludeSynth': 'Excluir Sintéticos', 'common.completeLp': 'Completar Lp', - 'common.asset.quickSelect': 'Selección Rápida L1' + 'common.asset.quickSelect': 'Selección Rápida L1', + 'common.asset.chooseAsset': 'Elige un activo' } export default common diff --git a/src/renderer/i18n/fr/common.ts b/src/renderer/i18n/fr/common.ts index 4fc37936e..2ce8e5c3b 100644 --- a/src/renderer/i18n/fr/common.ts +++ b/src/renderer/i18n/fr/common.ts @@ -145,6 +145,7 @@ const common: CommonMessages = { 'common.asset.base': 'Base', 'common.asset.change': "Changement d'actif", 'common.asset.quickSelect': 'Sélection rapide L1', + 'common.asset.chooseAsset': 'Choisissez un actif', 'common.noResult': 'Aucun résultat', 'common.rate': 'Taux', 'common.tx.type.swap': 'Échange', diff --git a/src/renderer/i18n/hi/common.ts b/src/renderer/i18n/hi/common.ts index d7352f410..b2db6dbf4 100644 --- a/src/renderer/i18n/hi/common.ts +++ b/src/renderer/i18n/hi/common.ts @@ -145,6 +145,7 @@ const common: CommonMessages = { 'common.asset.base': 'आधार', 'common.asset.change': 'संपत्ति बदलें', 'common.asset.quickSelect': 'त्वरित चयन L1', + 'common.asset.chooseAsset': 'एक संपत्ति चुनें', 'common.noResult': 'कोई परिणाम नहीं', 'common.rate': 'दर', 'common.tx.type.swap': 'अदला-बदली', diff --git a/src/renderer/i18n/ru/common.ts b/src/renderer/i18n/ru/common.ts index 924bc8d6d..8f95965b8 100644 --- a/src/renderer/i18n/ru/common.ts +++ b/src/renderer/i18n/ru/common.ts @@ -146,6 +146,7 @@ const common: CommonMessages = { 'common.asset.base': 'Базовый', 'common.asset.change': 'Сменить актив', 'common.asset.quickSelect': 'Быстрый выбор L1', + 'common.asset.chooseAsset': 'Выберите актив', 'common.noResult': 'Нет результата', 'common.rate': 'Курс', 'common.tx.type.swap': 'Обмен', diff --git a/src/renderer/i18n/types.ts b/src/renderer/i18n/types.ts index 3b4593fab..5914e54c7 100644 --- a/src/renderer/i18n/types.ts +++ b/src/renderer/i18n/types.ts @@ -148,6 +148,7 @@ export type CommonMessageKey = | 'common.asset.base' | 'common.asset.change' | 'common.asset.quickSelect' + | 'common.asset.chooseAsset' | 'common.noResult' | 'common.rate' | 'common.tx.type.swap' From a1e3b3ab75e7157b0abffbe55606ff2bf3c0f700 Mon Sep 17 00:00:00 2001 From: cinnamoroll6130 Date: Thu, 19 Sep 2024 20:29:13 -0400 Subject: [PATCH 2/7] update styles for scrollbar --- src/renderer/index.css | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/renderer/index.css b/src/renderer/index.css index c024b6bd3..22a154c8e 100644 --- a/src/renderer/index.css +++ b/src/renderer/index.css @@ -50,3 +50,23 @@ body { @apply transition duration-300 ease-in-out; } } + +/* Custom Scrollbar for WebKit Browsers */ +::-webkit-scrollbar { + width: 6px; /* Width of the scrollbar */ + height: 6px; /* Height of the scrollbar */ +} + +::-webkit-scrollbar-track { + background: #f1f1f1; /* Background of the scrollbar track */ + border-radius: 10px; /* Rounded corners */ +} + +::-webkit-scrollbar-thumb { + background: #888; /* Color of the scrollbar thumb */ + border-radius: 10px; /* Rounded corners */ +} + +::-webkit-scrollbar-thumb:hover { + background: #555; /* Color of the thumb on hover */ +} From 42c56a162dc781045df19b1f4fea45fe96d293d7 Mon Sep 17 00:00:00 2001 From: cinnamoroll6130 Date: Thu, 19 Sep 2024 20:29:31 -0400 Subject: [PATCH 3/7] add new dependency --- package.json | 1 + yarn.lock | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/package.json b/package.json index 5e197375b..47fba68e2 100644 --- a/package.json +++ b/package.json @@ -117,6 +117,7 @@ "bignumber.js": "9.0.0", "caniuse-lite": "^1.0.30001346", "chart.js": "^3.8.0", + "clsx": "^2.1.1", "cosmos-client": "0.39.2", "dayjs": "^1.11.10", "dotenv": "^16.4.5", diff --git a/yarn.lock b/yarn.lock index a8af8e11d..09199d940 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10028,6 +10028,7 @@ __metadata: browserify-fs: "npm:^1.0.0" caniuse-lite: "npm:^1.0.30001346" chart.js: "npm:^3.8.0" + clsx: "npm:^2.1.1" concurrently: "npm:^7.2.1" cosmos-client: "npm:0.39.2" cross-env: "npm:^7.0.3" @@ -11923,6 +11924,13 @@ __metadata: languageName: node linkType: hard +"clsx@npm:^2.1.1": + version: 2.1.1 + resolution: "clsx@npm:2.1.1" + checksum: 10/cdfb57fa6c7649bbff98d9028c2f0de2f91c86f551179541cf784b1cfdc1562dcb951955f46d54d930a3879931a980e32a46b598acaea274728dbe068deca919 + languageName: node + linkType: hard + "co@npm:^4.6.0": version: 4.6.0 resolution: "co@npm:4.6.0" From a1746dc3d5413eb6cbb86f3731bddf2bef214df6 Mon Sep 17 00:00:00 2001 From: cinnamoroll6130 Date: Thu, 19 Sep 2024 20:29:52 -0400 Subject: [PATCH 4/7] remove redundant spacing in classnames --- src/renderer/components/uielements/input/InputSearch.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/components/uielements/input/InputSearch.tsx b/src/renderer/components/uielements/input/InputSearch.tsx index 8bd5c3461..a65f06c27 100644 --- a/src/renderer/components/uielements/input/InputSearch.tsx +++ b/src/renderer/components/uielements/input/InputSearch.tsx @@ -87,7 +87,7 @@ export const InputSearch = forwardRef((props, ref): JSX } return ( -
+
Date: Thu, 19 Sep 2024 20:30:29 -0400 Subject: [PATCH 5/7] update asset select modal --- .../uielements/assets/assetMenu/AssetMenu.tsx | 99 +++++++++++-------- 1 file changed, 56 insertions(+), 43 deletions(-) diff --git a/src/renderer/components/uielements/assets/assetMenu/AssetMenu.tsx b/src/renderer/components/uielements/assets/assetMenu/AssetMenu.tsx index 0c43fe54d..9e744327f 100644 --- a/src/renderer/components/uielements/assets/assetMenu/AssetMenu.tsx +++ b/src/renderer/components/uielements/assets/assetMenu/AssetMenu.tsx @@ -4,6 +4,7 @@ import { Dialog, Transition } from '@headlessui/react' import { ArchiveBoxXMarkIcon, CheckIcon, XMarkIcon } from '@heroicons/react/24/outline' import { Network } from '@xchainjs/xchain-client' import { AnyAsset, assetToString, AssetType, Chain } from '@xchainjs/xchain-util' +import clsx from 'clsx' import * as A from 'fp-ts/lib/Array' import * as FP from 'fp-ts/lib/function' import * as NEA from 'fp-ts/lib/NonEmptyArray' @@ -15,7 +16,6 @@ import { eqAsset } from '../../../../helpers/fp/eq' import { emptyString } from '../../../../helpers/stringHelper' import { FilterCheckbox } from '../../../wallet/assets/AssetsTableCollapsable.styles' import { BaseButton } from '../../button' -import { Tooltip } from '../../common/Common.styles' import { InputSearch } from '../../input' import { Label } from '../../label' import { AssetData } from '../assetData' @@ -107,20 +107,19 @@ export const AssetMenu: React.FC = (props): JSX.Element => {
), (assets) => ( -
+
{FP.pipe( assets, NEA.map((assetInList) => { const selected = eqAsset.equals(asset, assetInList) return ( handleChangeAsset(assetInList)} disabled={selected}> - {selected && } + {selected && } ) }) @@ -168,18 +167,29 @@ export const AssetMenu: React.FC = (props): JSX.Element => { // Render unique chains as clickable icons in a horizontal row return ( -
- {/* Adjust Tailwind classes as needed */} - {Array.from(uniqueChains).map((chain) => ( -
handleChainSelect(chain)} className="cursor-pointer"> -
- +
+
+ {intl.formatMessage({ id: 'common.asset.quickSelect' })} +
+
+ {Array.from(uniqueChains).map((chain) => ( +
handleChainSelect(chain)} className="cursor-pointer"> +
+ + {chain} +
-
- ))} + ))} +
) - }, [assets, handleChainSelect, network]) + }, [assets, handleChainSelect, network, intl]) // Ref to `InputSearch` - needed for intial focus in dialog // @see https://headlessui.com/react/dialog#managing-initial-focus @@ -216,44 +226,47 @@ export const AssetMenu: React.FC = (props): JSX.Element => { leaveFrom="opacity-100 scale-100" leaveTo="opacity-0 scale-95"> - onClose()}> - - - {headline && ( -

- {headline} -

- )} + className={clsx( + 'mx-auto flex flex-col items-center py-5', + 'h-3/4 max-h-[600px] min-h-[350px] w-full max-w-[360px] md:max-w-[480px]', + 'bg-bg0 dark:bg-bg0d', + 'rounded-lg border border-solid border-gray1 dark:border-gray0d' + )}> +
+ {headline && ( +

{headline}

+ )} + onClose()}> + + +
+
{chainFilter} - +
- - -
- - setExcludeSynth(e.target.checked)} - /> +
+ + setExcludeSynth(e.target.checked)} + /> +
{renderAssets} From cb6242e18d8d3d95bfdccc54e49515e422764692 Mon Sep 17 00:00:00 2001 From: cinnamoroll6130 Date: Thu, 19 Sep 2024 20:30:46 -0400 Subject: [PATCH 6/7] update headline for asset select modal --- .../components/uielements/assets/assetInput/AssetInput.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/components/uielements/assets/assetInput/AssetInput.tsx b/src/renderer/components/uielements/assets/assetInput/AssetInput.tsx index 909bf7b70..2e39090da 100644 --- a/src/renderer/components/uielements/assets/assetInput/AssetInput.tsx +++ b/src/renderer/components/uielements/assets/assetInput/AssetInput.tsx @@ -179,7 +179,7 @@ export const AssetInput: React.FC = (props): JSX.Element => { asset={asset} assets={assets} network={network} - dialogHeadline={intl.formatMessage({ id: 'common.asset.quickSelect' })} + dialogHeadline={intl.formatMessage({ id: 'common.asset.chooseAsset' })} shadowless disabled={disabled} /> From 0ce6808d6059a26a80a10bd22c5642ecc4aa315e Mon Sep 17 00:00:00 2001 From: cinnamoroll6130 Date: Thu, 19 Sep 2024 20:33:06 -0400 Subject: [PATCH 7/7] update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ca553c03f..14e700aed 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,10 +1,12 @@ # 1.22.5 (2024-09-6) ## Updates/Fixes + - Add trade asset table [#321](https://github.com/asgardex/asgardex-desktop/pull/322) - add saved address to send screen [#343](https://github.com/asgardex/asgardex-desktop/pull/349) - fix asset mismatch and lp retrieval tool [350](https://github.com/asgardex/asgardex-desktop/pull/351) - redesign swap screen [#359](https://github.com/asgardex/asgardex-desktop/pull/359) +- redesign asset select modal [#362](https://github.com/asgardex/asgardex-desktop/pull/362) # 1.22.4 (2024-09-6)