-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set default shell version values on POSIX entrypoint #1594
fix: Set default shell version values on POSIX entrypoint #1594
Conversation
Nice catch! To properly address this, the variables cannot be exported and should not be assigned to because this changes the shell environment. So the |
7c1232c
to
ebe7310
Compare
@hyperupcall |
LGTM! Waiting for other maintainers to give feedback / take action |
Happy to see that this fix is available already so I don't have to file it myself. 🙇:blush: |
But unfortunately, it has not yet been approved and released 😢 |
I would merge this if I could - the maintainers seem to be merging things less frequently these days. For now, I have cherry-picked this commit (and others from other PRs) into fox-incubating/asdf, one of my forks. All I can do is release a new version from my fork. I plan to add other features as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! And thanks for the review @hyperupcall 🙇♂️
Summary
Add default values for
BASH_VERSION
,ZSH_VERSION
,KSH_VERSION
.Shell which sets option
nounset
occurs following error.$ /opt/homebrew/opt/asdf/libexec/asdf.sh:68: BASH_VERSION: parameter not set