Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support nushell v0.75.0 #1481

Merged
merged 1 commit into from
Feb 19, 2023
Merged

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Feb 19, 2023

Summary

Ever since Nushell v0.75.0 was released on homebrew, our CI fails (see #1479, #1480, and #1482). This fixes the Nushell tests to be compatible with the latest version

The only necessary change is the export extern "asdf" => export extern main, which is due to recent module changes.

Everything else is just whitespace and improved test reliability. The tests pass on v0.75.0 and earlier (not just v0.75.0).

@hyperupcall hyperupcall requested a review from a team as a code owner February 19, 2023 06:48
@hyperupcall hyperupcall changed the title fix Nushell tests for v0.75.0 test: Fix Nushell tests for v0.75.0 Feb 19, 2023
@hyperupcall hyperupcall changed the title test: Fix Nushell tests for v0.75.0 chore: Fix Nushell tests for v0.75.0 Feb 19, 2023
@hyperupcall hyperupcall changed the title chore: Fix Nushell tests for v0.75.0 test: Fix Nushell tests for v0.75.0 Feb 19, 2023
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@jthegedus jthegedus changed the title test: Fix Nushell tests for v0.75.0 fix: support nushell v0.75.0 Feb 19, 2023
@jthegedus jthegedus merged commit dd8d399 into asdf-vm:master Feb 19, 2023
@jthegedus
Copy link
Contributor

Made this a fix: since it touches code executed by users.

@hyperupcall hyperupcall deleted the fix-nushell-test branch February 21, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants