Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Directus support #46

Merged
merged 6 commits into from
Apr 22, 2023
Merged

feat: add Directus support #46

merged 6 commits into from
Apr 22, 2023

Conversation

danestves
Copy link
Contributor

Internally at Kazel we use a custom transformer to display the images of our backend to our frontend, I moved all the code to here since there is an issue open about it, added tests and an example image which you can test.

Closes #36

@danestves danestves requested a review from ascorbic April 19, 2023 19:17
Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wanted to add support for manually setting the CDN to the playground so I coiuld tests this there. I did that today and it works great!

@ascorbic ascorbic merged commit 3be1fe3 into ascorbic:main Apr 22, 2023
@mixie-bot mixie-bot bot mentioned this pull request Apr 22, 2023
@danestves danestves deleted the feat/directus branch April 23, 2023 17:12
@ascorbic
Copy link
Owner

ascorbic commented Aug 1, 2023

@danestves the sample URL that you provided here is no longer resolving, menaing the Directus tests no longer pass. Would you have a stable sample image URL it could be switched for?

@mixie-bot mixie-bot bot mentioned this pull request Dec 7, 2024
@mixie-bot mixie-bot bot mentioned this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Directus file transformation API
2 participants