resolves #1507 introduce an in-memory cache (Node.js) #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
force-pushed
the
issue-1507-content-uri-cache
branch
2 times, most recently
from
ea1863b
to
a59b15d
Compare
|
This pull request provides a custom implement of This pull requests also introduces an API to interact with the cache: Asciidoctor.Cache.enable()
Asciidoctor.Cache.disable()
Asciidoctor.Cache.setMax(500)
Asciidoctor.Cache.reset() |
ggrossetie
force-pushed
the
issue-1507-content-uri-cache
branch
from
a59b15d
to
b7c1940
Compare
ggrossetie
commented
Dec 31, 2021
ggrossetie
force-pushed
the
issue-1507-content-uri-cache
branch
from
b7c1940
to
a938a6a
Compare
ggrossetie
force-pushed
the
issue-1507-content-uri-cache
branch
from
a938a6a
to
aba02c0
Compare
ggrossetie
commented
Apr 24, 2022
Comment on lines
+28
to
+33
| def require_library name, gem_name = true, on_failure = :abort | ||
| if name == 'open-uri/cached' | ||
| `return Opal.Asciidoctor.Cache.enable()` | ||
| end | ||
| original_require_library name, gem_name, on_failure | ||
| end |
There was a problem hiding this comment.
@mojavelinux I'm a bit concerned about this hack, could we find a better "hook" in Asciidoctor core?
|
Waiting for a change in Asciidoctor core to properly hook the in-memory cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1507