Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement asciidoctor-doctest testing #92

Closed
2 tasks done
obilodeau opened this issue Sep 6, 2016 · 7 comments
Closed
2 tasks done

Implement asciidoctor-doctest testing #92

obilodeau opened this issue Sep 6, 2016 · 7 comments
Labels
🍩 improvement
Milestone
1.1.0

Comments

@obilodeau
Copy link
Member

obilodeau commented Sep 6, 2016 •
edited
Loading

We should implement asciidoctor-doctest. See asciidoctor-backends for an example implementation.

Idea / suggestion came from @jirutka during this discussion #63.

  • migrate from Makefile and manual tests to asciidoctor-doctest
  • create travis-ci integration and run doctest as part of build
@obilodeau obilodeau added this to the 1.0 milestone Sep 6, 2016
@obilodeau obilodeau mentioned this issue Sep 27, 2016
Closed
@obilodeau obilodeau modified the milestones: 1.0, 1.1 Oct 5, 2016
@obilodeau
Copy link
Member Author

As mentioned by @mojavelinux, we should use rake for tests

@jirutka
Copy link
Member

jirutka commented Oct 5, 2016

Rake for tests? o.O Rake is like Make…

@obilodeau
Copy link
Member Author

To run the tests, instead of make

@obilodeau
Copy link
Member Author

See #110 (comment)

@obilodeau
Copy link
Member Author

Faced a problem trying to get the tests to run, filed a bug to upstream project in order to get help: asciidoctor/asciidoctor-doctest#11

For anyone interested, work-in-progress branch is here: obilodeau/asciidoctor-reveal.js

It is, again, due to my misunderstanding of the whole gem, bundler and ruby packaging ecosystem...

@obilodeau obilodeau mentioned this issue Oct 27, 2016
Merged
5 tasks
@obilodeau
Copy link
Member Author

Making some progress. Until further notice, refer to the pull request #116 to follow what is happening.

@obilodeau
Copy link
Member Author

With #116 in master, this has been implemented.

@snyk-bot snyk-bot mentioned this issue Dec 19, 2020
Open
@snyk-bot snyk-bot mentioned this issue Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍩 improvement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@obilodeau @jirutka