-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integer values of Reveal.js options are not set by template #312
Comments
I built a simple deck to reproduce your issue: = Title Slide
:revealjsdir: reveal.js
:revealjs_defaultTiming: 60
:revealjs_autoSlide: 10000
== Slide One
* Foo
* Bar
* World
== Slide Two
Hello World
[NOTE.speaker]
--
Testing
--
== Slide Trois
Fancy
I can see that default timing is also set to 60 in the javascript but it is not visible in the speaker notes to me. I'm unsure why and maybe I'm not looking at the right place since I never used that feature. |
It looks like slides pacing ( Run a simple web server, load your slide deck through it, hit To me, both feature work as expected. With the caveats of using a web server for speaker notes but that also has been documented in the reveal.js repo. |
Hi ! I will try to find out what happens in my case. I am using the asciidoctor.js converter. Maybe the problem comes from here. If you want to reproduce, just clone https://github.com/ncomet/oss-koson-2020 I've set the defaultTiming option (to 40) in Then run The problem appears in the generated slides.html file, you can check by searching for defaultTiming in the source. (I temporarily solved this by manually sed-ing the generated slides.html and the server took the 40s time allowed for one slide without any issue) Once it it served by github pages, everything is fine. |
My tests were done with the JavaScript stack so it should not be the cause
of the issue. Using reveal.js 3.7.0.
If you look at the resulting HTML is the 60 value rendered properly and is
valid javascript?
|
I tried : :revealjs_defaultTiming: 40 No matter what the html output is :
It is valid JS, but somehow the value is not picked up. |
According to your repo, you are using a version with a bug: https://github.com/ncomet/oss-koson-2020/blob/master/package-lock.json#L71.
See #263 (comment) for details. 2.0.1 fixes that problem. However, the latest version (and the one I tested) is 3.0.0 but there is a font-awesome issue so 3.0.1 should be released soon. |
Thanks a lot, it was indeed a bug of 2.0.0. I close the issue. |
It seems integer values of options
for instance, are not set properly by template.
It works fine with boolean and textual values though.
The text was updated successfully, but these errors were encountered: