Attempt at making Travis happy about Asciidoctor 2.0 #216
Conversation
Right now asciidoctor-reveal.js builds fails with asciidoctor-doctest complains because of strict dependency requirements. See asciidoctor/asciidoctor-reveal.js#216. I'm not sure this is the right way to fix it but we need to think about it.
|
Some issues are upstream like in asciidoctor-doctest. I'm sure they'll get handled in a timely fashion. Not that we are in a rush, 2.0 dev started today so it shouldn't appear overnight. Yay CI-testing with upstream in mind 😄 |
|
For compatibility with 1.5.8, you should add a dependency on the concurrent-ruby gem. You can still depend on thread_safe too. As long as both gems are present, it will work on both 1.5.7 and 1.5.8 without any warnings. For compatibility with 2.0.0, you'd drop (exclude) the following rvms from the upstream build matrix:
Aside from that, I expect everything to work the same. |
|
If you look at Travis, you will see that the problem is asciidoctor-doctest
using `~> 1.5.0` (like we were doing). Sent them a PR.
Curious, why is the dep on thread_safe or concurrent isn't done upstream in
your gemfile? Why do we have to specify it downstream?
Le mar. 30 oct. 2018 2 h 28 a.m., Dan Allen <notifications@github.com> a
écrit :
… For compatibility with 1.5.8, you should add a dependency on the
concurrent-ruby gem. You can still depend on thread_safe too. As long as
both gems are present, it will work on both 1.5.7 and 1.5.8 without any
warnings.
For compatibility with 2.0.0, you'd drop (exclude) the following rvms from
the upstream build matrix:
- 2.2
- 2.1
Aside from that, I expect everything to work the same.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAhWFVowBYjv70D8NKZYaR71YuVtHP2tks5up_GngaJpZM4YBKmR>
.
|
|
Ah, yes, that makes sense. 2.0.0 will not introduce any API changes, so it's safe to upgrade just as you would a 1.5.x release. We're just reestablishing the major version so that we can start following semantic versioning from that point forward. Still, you'll want to drop 2.1 and 2.2 as they are no longer officially supported by the Ruby language project.
Asciidoctor core has a policy of having 0 dependencies. On top of that, it's only a recommended dependency, not a required one. And, btw, it's now concurrent-ruby, not thread_safe. Though, for it to work without warning on both 1.5.7 and 1.5.8, you'll need both on the load path. |
Upstream as a 0 dependency policy. This is why they are defined here. They will improve performance and eliminate warnings.
Right now asciidoctor-reveal.js builds fails with asciidoctor-doctest complains because of strict dependency requirements. See asciidoctor/asciidoctor-reveal.js#216.
Right now asciidoctor-reveal.js builds fails with asciidoctor-templates-compiler complains because of strict dependency requirements. Asciidoctor 2.0 is on the way and will be compatible with 1.5.8. See asciidoctor/asciidoctor-reveal.js#216.
Rewrote Minimum requirements README section. * Covers bundler and npm with links * Linked the README to upstream's Asciidoctor requirements since all further requirement our project introduces are satisfied by Ruby packages * Added a link to Asciidoctor.js too. There are no explicit requirements but the package.json will enumerate them.
a-t-c: asciidoctor-templates-compiler
|
All tests are green! Two TODOs of using specific repositories until the dependencies merge and do a release:
I'm going to merge early because this makes current failing tests pass (due to Asciidoctor's 2.0 migration). I don't like to see failing tests all over the place while I'm prepping a release. Edit: clarified last sentence, the meaning was reversed |
Right now asciidoctor-reveal.js builds fails with asciidoctor-templates-compiler complains because of strict dependency requirements. Asciidoctor 2.0 is on the way and will be compatible with 1.5.8. See asciidoctor/asciidoctor-reveal.js#216.
No description provided.