Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin customizations are ignored if configuration cache is enabled #44

Closed
dmitry-ryadnenko-izettle opened this issue May 4, 2022 · 6 comments · Fixed by #47
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dmitry-ryadnenko-izettle
Copy link

dmitry-ryadnenko-izettle commented May 4, 2022

Describe the bug

Build times are not sorted if build configuration is restored from Gradle configuration cache.

When configuration phase is properly executed (configuration is not restored from the cache) then everything is sorted as expected.

To Reproduce

Use sortBy = com.asarkar.gradle.buildtimetracker.Sort.ASC
Gradle has configuration cache enabled.
Make sure build configuration is restored from the Gradle configuration cache. By executing the build second time without changing gradle files for example.

Expected behavior

Build times are sorted.

Environment

  • build-time-tracker plugin version: 4.2.0
  • OS: Mac OS
  • Gradle version: 7.2
  • JDK version: 11
@dmitry-ryadnenko-izettle dmitry-ryadnenko-izettle added the bug Something isn't working label May 4, 2022
@asarkar
Copy link
Owner

asarkar commented May 4, 2022

Make sure build configuration is restored from the Gradle configuration cache

by this, do you mean running with —configuration-cache?

@asarkar asarkar added the waiting-feedback Further information is requested label May 4, 2022
@dmitry-ryadnenko-izettle
Copy link
Author

Make sure build configuration is restored from the Gradle configuration cache

by this, do you mean running with —configuration-cache?

Yes

@asarkar asarkar removed the waiting-feedback Further information is requested label May 5, 2022
@asarkar
Copy link
Owner

asarkar commented May 5, 2022

I think I've been able to reproduce the bug, and have an idea what is causing it. For the record, the first execution works as expected, but subsequent executions don't.
I'm looking into it and will report back with more information when I've found a solution.

@asarkar asarkar changed the title Build times are not sorted if build configuration is restored from Gradle configuration cache Plugin customizations are ignored if configuration cache is enabled May 5, 2022
@asarkar asarkar added this to the 4.3.0 milestone May 5, 2022
@asarkar asarkar self-assigned this May 5, 2022
@asarkar
Copy link
Owner

asarkar commented May 5, 2022

@dmitry-ryadnenko-izettle I've made a fix on this branch as version 4.3.0-rc. Please verify and let me know. You can find instructions here.

Also see discussion #45 on the topic of Configuration Cache.

@asarkar asarkar added the waiting-feedback Further information is requested label May 5, 2022
@dmitry-ryadnenko-izettle
Copy link
Author

@asarkar Works like a charm 😊

@asarkar asarkar removed the waiting-feedback Further information is requested label May 5, 2022
@asarkar
Copy link
Owner

asarkar commented May 6, 2022

v4.3.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants