Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing dependency on http download for radon dataset #1716

Closed
canyon289 opened this issue Jun 5, 2021 · 4 comments · Fixed by #1717
Closed

Remove testing dependency on http download for radon dataset #1716

canyon289 opened this issue Jun 5, 2021 · 4 comments · Fixed by #1717

Comments

@canyon289
Copy link
Member

canyon289 commented Jun 5, 2021

Describe the bug
Loading radon dataset is causing network failures in tests. We should remove this dependency anyway since we want our tests to be as isolated as possible.

https://github.com/arviz-devs/arviz/blob/main/arviz/tests/base_tests/test_stats.py#L607

To Reproduce
See CI pipeline here
https://dev.azure.com/ArviZ/ArviZ/_build/results?buildId=4434&view=logs&j=e9e5789a-ef7e-54d7-c525-bfdc535bcf80&t=85614d98-b825-523f-f666-d210d5fbfe6e&l=359

Reference PR where we first noticed this #1710

Expected behavior
We test def test_loo_pit_multi_lik(): without need for external radon dataset

Additional context

@canyon289 canyon289 changed the title Remove dependency on radon for tests Remove testing dependency on http download for radon dataset Jun 5, 2021
@canyon289
Copy link
Member Author

@utkarsh-maheshwari assigning this to you for now so you have first right of refusal

@utkarsh-maheshwari
Copy link
Contributor

I think task is to create inferencedata with multiple log_likelihood variables, without using any external datasets.
However, internal datsets like

model_1 = create_model(seed=10)
can be called inside test_loo_pit_multi_lik() and then adding to it an extra log_likelihood variable with random values would do our work.

@utkarsh-maheshwari
Copy link
Contributor

Also, size of the new variable doesn't matter. It could be anything.

@utkarsh-maheshwari
Copy link
Contributor

But I didn't actually understand the significance of this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants