-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove testing dependency on http download for radon dataset #1716
Comments
@utkarsh-maheshwari assigning this to you for now so you have first right of refusal |
I think task is to create Line 181 in 4d9caca
test_loo_pit_multi_lik() and then adding to it an extra log_likelihood variable with random values would do our work.
|
Also, size of the new variable doesn't matter. It could be anything. |
But I didn't actually understand the significance of this test. |
Describe the bug
Loading radon dataset is causing network failures in tests. We should remove this dependency anyway since we want our tests to be as isolated as possible.
https://github.com/arviz-devs/arviz/blob/main/arviz/tests/base_tests/test_stats.py#L607
To Reproduce
See CI pipeline here
https://dev.azure.com/ArviZ/ArviZ/_build/results?buildId=4434&view=logs&j=e9e5789a-ef7e-54d7-c525-bfdc535bcf80&t=85614d98-b825-523f-f666-d210d5fbfe6e&l=359
Reference PR where we first noticed this #1710
Expected behavior
We test
def test_loo_pit_multi_lik():
without need for external radon datasetAdditional context
The text was updated successfully, but these errors were encountered: