Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelatedArtistsModule #1136

Closed
briansw opened this issue Feb 10, 2016 · 7 comments
Closed

RelatedArtistsModule #1136

briansw opened this issue Feb 10, 2016 · 7 comments

Comments

@briansw
Copy link
Contributor

briansw commented Feb 10, 2016

related-artists-module

@alloy
Copy link
Contributor

alloy commented Feb 15, 2016

  • Do we ever only show a max of 4 artists on iPhone and 6 on iPad?
  • If not, is there a limit? And how are these shown?

@briansw
Copy link
Contributor Author

briansw commented Feb 15, 2016

From what I can tell it looks like the max set to 16—let's keep it at 16 for now.

@alloy
Copy link
Contributor

alloy commented Feb 15, 2016

Ok.

@sarahscott
Copy link
Contributor

@alloy eyeing this component: https://github.com/lucholaf/react-native-grid-view after reading this discussion: facebook/react-native#638

@alloy
Copy link
Contributor

alloy commented May 4, 2016

Sounds good. Skim through the code of the lib to see if it's not massively complex and it all makes sense to you, then go for it!

@alloy
Copy link
Contributor

alloy commented May 4, 2016

@sarahscott I think that you can do these grids with just flexbox btw, no grid view needed.

The reason for a more fancy grid view is to optimise when you have large, potentially infinite lists. Like ListView it removes cells from the hierarchy when they’re offscreen and recycles view objects. But in our case it’s just 16.

@alloy
Copy link
Contributor

alloy commented May 29, 2016

This is done v1 of Emission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants