Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki link to local file without a heading should not be dectected as "anbiguous" and error out. #319

Closed
unifreak opened this issue Jul 2, 2024 · 3 comments
Labels
needs-further-input Further information is required from the reporter

Comments

@unifreak
Copy link

unifreak commented Jul 2, 2024

(Firstly, thanks for this amazing software!)

Problem:

I'm using Emacs with Eglot. Say I have a file another-note.md, and when referencing it as [[another-note]], marksman will detect it as "ambiguous", when doing goto-definition on it, Emacs will open up a xref buffer showing a list of available headings for jump, instead of just open up that file.

This conflict with marksmans documentation here:

  • Wiki-links:
    Link to [[another-note]].
    Link to [[another-notes#heading]].
    Internal link to [[#a-heading]].

I also tried [[another-note.md]], [[another-note#]] , [[./another-note.md]], all are treated as "ambiguous".

The related issues might be: #177 #310 .

@artempyanykh
Copy link
Owner

@unifreak does you file have several level-1 headings, e.g.:?

# Heading 1
blabla

# Heading 2
blabla

Level 1 heading is considered a title and is expected to be unique in a document.

@artempyanykh artempyanykh added the needs-further-input Further information is required from the reporter label Jul 6, 2024
@unifreak
Copy link
Author

unifreak commented Jul 7, 2024

@artempyanykh You're right, I do have multiple level-one headings in other-note, didn't realize this is a markdown syntax issue. But can we have this: for [[another-note]], just open that file at beginning? I don't want the headings nested too much.

Anyway, now I know it's not an issue of marksman, I can just adjust my note's structure. Thanks!

@artempyanykh
Copy link
Owner

I think this should be addressed in 2024-12-04. Please, report if something doesn't work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-further-input Further information is required from the reporter
Projects
None yet
Development

No branches or pull requests

2 participants