Test that verapdf validate path exists

Author: djjuhasz

internal/fvalidate/verapdf_validator.go

@@ -2,9 +2,12 @@ package fvalidate
 
 import (
 	"errors"
+	"fmt"
 	"os/exec"
 
 	"github.com/go-logr/logr"
+
+	"github.com/artefactual-sdps/preprocessing-sfa/internal/fsutil"
 )
 
 // pdfaPUIDs are the https://www.nationalarchives.gov.uk/pronom/ IDs of the
@@ -48,6 +51,10 @@ func (v *veraPDFValidator) Validate(path string) (string, error) {
 		return "", nil
 	}
 
+	if !fsutil.FileExists(path) {
+		return "", fmt.Errorf("validate: file not found: %s", path)
+	}
+
 	cmd := exec.Command(v.cmd, "--recurse", path) // #nosec: G204 -- trusted path.
 
 	_, err := cmd.Output()

internal/fvalidate/verapdf_validator_test.go

@@ -0,0 +1,96 @@
+package fvalidate_test
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/go-logr/logr"
+	"gotest.tools/v3/assert"
+
+	"github.com/artefactual-sdps/preprocessing-sfa/internal/fvalidate"
+)
+
+func TestFormatIDs(t *testing.T) {
+	t.Parallel()
+
+	v := fvalidate.NewVeraPDFValidator("", logr.Discard())
+	got := v.FormatIDs()
+
+	assert.DeepEqual(t, got, []string{
+		"fmt/95",   // PDF/A 1a
+		"fmt/354",  // PDF/A 1b
+		"fmt/476",  // PDF/A 2a
+		"fmt/477",  // PDF/A 2b
+		"fmt/478",  // PDF/A 2u
+		"fmt/479",  // PDF/A 3a
+		"fmt/480",  // PDF/A 3b
+		"fmt/481",  // PDF/A 3u
+		"fmt/1910", // PDF/A 4
+		"fmt/1911", // PDF/A 4e
+		"fmt/1912", // PDF/A 4f
+	})
+}
+
+func TestName(t *testing.T) {
+	t.Parallel()
+
+	v := fvalidate.NewVeraPDFValidator("", logr.Discard())
+	got := v.Name()
+
+	assert.Equal(t, got, "veraPDF")
+}
+
+func empty(td string) string {
+	return ""
+}
+
+func TestValidate(t *testing.T) {
+	t.Parallel()
+
+	type test struct {
+		name    string
+		cmd     string
+		path    func(td string) string
+		want    func(td string) string
+		wantErr func(td string) string
+	}
+	for _, tt := range []test{
+		{
+			name: "Does nothing when cmd is not set",
+			path: empty,
+		},
+		{
+			name: "Errors when path doesn't exist",
+			cmd:  "echo",
+			path: func(td string) string { return td + "/foo" },
+			wantErr: func(td string) string {
+				return fmt.Sprintf("validate: file not found: %s/foo", td)
+			},
+		},
+		{
+			name: "Returns nothing when no error",
+			cmd:  "echo",
+			path: func(td string) string { return td },
+		},
+	} {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
+			v := fvalidate.NewVeraPDFValidator(tt.cmd, logr.Discard())
+			td := t.TempDir()
+			got, err := v.Validate(tt.path(td))
+			if tt.wantErr != nil {
+				assert.Error(t, err, tt.wantErr(td))
+				return
+			}
+
+			assert.NilError(t, err)
+
+			if tt.want != nil {
+				assert.Equal(t, got, tt.want(td))
+			} else {
+				assert.Equal(t, got, "")
+			}
+		})
+	}
+}