From 9bc6deb9a9fbb58fbdeed42f0f832c6defb198b8 Mon Sep 17 00:00:00 2001
From: David Juhasz <djjuhasz@gmail.com>
Date: Wed, 4 Dec 2024 17:42:20 -0800
Subject: [PATCH] More preservation task card fixes

- Reduce size of card title
- Show only "started" or "completed" time
- Always display status badge in top right corner of card
- Attempt to truncate long title text with new "flex-truncate" class
  (doesn't work)
---
 .../components/PreservationActionCollapse.vue | 54 ++++++++++++-------
 dashboard/src/styles/main.scss                |  5 ++
 2 files changed, 39 insertions(+), 20 deletions(-)

diff --git a/dashboard/src/components/PreservationActionCollapse.vue b/dashboard/src/components/PreservationActionCollapse.vue
index fa49924e0..907c93c7a 100644
--- a/dashboard/src/components/PreservationActionCollapse.vue
+++ b/dashboard/src/components/PreservationActionCollapse.vue
@@ -1,6 +1,10 @@
 <script setup lang="ts">
 import type { api } from "@/client";
 import PackageReviewAlert from "@/components/PackageReviewAlert.vue";
+import type {
+  EnduroPackagePreservationTask,
+  EnduroPackagePreservationTaskStatusEnum,
+} from "@/openapi-generator";
 import StatusBadge from "@/components/StatusBadge.vue";
 import { useAuthStore } from "@/stores/auth";
 import Collapse from "bootstrap/js/dist/collapse";
@@ -54,6 +58,10 @@ watch(toggleAll, () => {
 
 let expandCounter = ref<number>(0);
 watch(expandCounter, () => show());
+
+function isComplete(task: EnduroPackagePreservationTask) {
+  return task.status == "done" || task.status == "error";
+}
 </script>
 
 <template>
@@ -124,39 +132,45 @@ watch(expandCounter, () => show());
         class="mb-2 card"
       >
         <div class="card-body">
-          <div class="d-flex flex-row gap-3">
-            <div class="fd-flex align-self-start">
+          <div class="d-flex flex-row align-start gap-3">
+            <div class="fd-flex">
               <span
-                class="badge rounded-pill fs-6 border border-primary text-primary"
+                class="fs-6 badge rounded-pill border border-primary text-primary"
               >
                 {{ action.tasks.length - index }}
               </span>
             </div>
             <div class="d-flex flex-column flex-grow-1 align-content-stretch">
-              <div class="d-flex flex-wrap">
-                <div class="flex-grow-1 me-3">
-                  <span class="fs-5 fw-bold">{{ task.name }}</span>
-                </div>
-                <div
-                  v-if="$filters.formatDateTime(task.startedAt)"
-                  class="me-3"
-                >
-                  Started: {{ $filters.formatDateTime(task.startedAt) }}
+              <div class="d-flex flex-wrap pt-1">
+                <div class="me-auto flex-truncate fw-bold">
+                  {{ task.name }}
                 </div>
-                <div
-                  v-if="$filters.formatDateTime(task.completedAt)"
-                  class="me-3"
-                >
-                  Completed: {{ $filters.formatDateTime(task.completedAt) }}
-                </div>
-                <div>
-                  <StatusBadge :status="task.status" />
+                <div class="me-3">
+                  <span
+                    v-if="
+                      !isComplete(task) &&
+                      $filters.formatDateTime(task.startedAt)
+                    "
+                  >
+                    Started: {{ $filters.formatDateTime(task.startedAt) }}
+                  </span>
+                  <span
+                    v-if="
+                      isComplete(task) &&
+                      $filters.formatDateTime(task.completedAt)
+                    "
+                  >
+                    Completed: {{ $filters.formatDateTime(task.completedAt) }}
+                  </span>
                 </div>
               </div>
               <div class="d-flex flex-row gap-4">
                 <div class="flex-grow-1 line-break">{{ task.note }}</div>
               </div>
             </div>
+            <div class="d-flex pt-1">
+              <StatusBadge :status="task.status" />
+            </div>
           </div>
         </div>
       </div>
diff --git a/dashboard/src/styles/main.scss b/dashboard/src/styles/main.scss
index dc3c46478..09a68db98 100644
--- a/dashboard/src/styles/main.scss
+++ b/dashboard/src/styles/main.scss
@@ -29,3 +29,8 @@ a:not(.btn),
 .line-break {
   white-space: break-spaces;
 }
+
+.flex-truncate {
+  @extend .text-truncate;
+  min-width: 0;
+}