Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding native/custom PiP buttons to popular sites #12

Open
arnoappenzeller opened this issue Oct 16, 2016 · 22 comments
Open

Adding native/custom PiP buttons to popular sites #12

arnoappenzeller opened this issue Oct 16, 2016 · 22 comments

Comments

@arnoappenzeller
Copy link
Owner

arnoappenzeller commented Oct 16, 2016

2d783e0 adds the possibility to enable custom PiP in the video player of popular pages. This option is enabled by default since I find the inline PiP much more useful.

One major advantage is that this doesn't require any other interaction that you would need for autoplaying video players.

At the moment this feature only supports Youtube.

Here is an updating list of video players that are supported/deprecated(because they added their own button)/wished:

  • Supported:
    • Youtube
    • videoJS players (should have basic support)
    • Netflix
    • Wistia Players
  • Deprecated:
  • Wishlist:
    • Twitch.tv
    • ZDF Mediathek
    • ARD Mediathek
    • JW Player
    • Plex
    • Amazon Video
    • Facebook

If you have any player you want to see supported don't hesitate and I add it to the wishlist

@RvMouche
Copy link

A native player in videoJS players would be neat

@arnoappenzeller
Copy link
Owner Author

Should be possible but there needs to be a clever way to detect the videoJS players because currently the native placement works via the domain.

@arnoappenzeller
Copy link
Owner Author

365c03b adds basic support for video.js players.

But I'm lacking a bit of real world examples. @RvMouche do you have some maybe?

@kwokaaron
Copy link

Slightly off-topic, but wanted to check the feasibility of this first. I was wondering with the addition of the custom PiP buttons in the video players on popular pages, is it possible to provide an option to disable this feature as well in the extension settings?

@arnoappenzeller
Copy link
Owner Author

arnoappenzeller commented Oct 18, 2016

The main app has an option to disable it so if a problem would occur this would be a workaround till a fix
bildschirmfoto 2016-10-18 um 20 54 39

@kwokaaron
Copy link

kwokaaron commented Oct 18, 2016

Ah sorry about that, I only checked to see if there was an option to do this in the Safari preference 'Extensions' tab. Thanks!

@arnoappenzeller
Copy link
Owner Author

Don't worry I wanted to add it there in the first place but it seems not possible anymore with the new Safari Extension API

@kwokaaron
Copy link

Got it. Got slightly confused since my old extensions previously installed in Safari still shows this.

@kwokaaron
Copy link

kwokaaron commented Oct 18, 2016

There seems to be a bug where it reappears. It seems to work on the very first page load, but refreshing the youtube video page seems to show the button again. Should I make a new issue for this?

@arnoappenzeller
Copy link
Owner Author

Did you disable it and then it reappears?

@kwokaaron
Copy link

Yes. I've even tried uninstalling it and deleting all the containers.

@arnoappenzeller
Copy link
Owner Author

arnoappenzeller commented Oct 19, 2016

This should be considered as a bug and is noted in issue #15

@akeonline
Copy link

Hi, am using JW Player (flash) on streamtvbox website, but the button doesn't seem to appear to be able to click it, I've tried pausing and playing, nothing seems to work? Any help would be greatly appreciated, thanks.

@arnoappenzeller
Copy link
Owner Author

Flash is not supported by PiP mode in Sierra so this is not possible. Also this is not the right issue for it so I'll clean this up in a bit

@ghost
Copy link

ghost commented Oct 30, 2016

Maybe outdated, but unfortunately some websites still use Silverlight (by Microsoft). I'm just wondering if it would be possible to see PiPifier supporting those videos in some future update?

PS: Just downloaded it from the AppStore and I'm quite happy with it. Thanks!

@arnoappenzeller
Copy link
Owner Author

@WillyH93 unfortunately PiP on Sierra supports only HTML5 videos. So Silverlight can't be supported at the moment

@WilliamBlais
Copy link

Would be awesome to add Udemy.

@JoniVR
Copy link

JoniVR commented Mar 24, 2017

@WilliamBlais As far as I'm aware, it already supports Udemy, for me the button is on the bottom left next to play
screenshot

@tonycoco
Copy link

What about Facebook?

@adavidzh
Copy link

I was wondering about support for RTP since that uses the HTML5 Radiant Media Player.

@olliebaum
Copy link

So, it's not strictly a video player... but would it be possible to add support for Tumblr TV. I like to have GIFs playing in the background while I work. Would be neat to have it in PiP.

@floriandierickx
Copy link

To add to the wishlist: THEOPLayer would be nice. It is used by vualto, .. to stream NBC, CNN, Vrt (belgian public broadcasting), ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants