-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding native/custom PiP buttons to popular sites #12
Comments
A native player in videoJS players would be neat |
Should be possible but there needs to be a clever way to detect the videoJS players because currently the native placement works via the domain. |
Slightly off-topic, but wanted to check the feasibility of this first. I was wondering with the addition of the custom PiP buttons in the video players on popular pages, is it possible to provide an option to disable this feature as well in the extension settings? |
Ah sorry about that, I only checked to see if there was an option to do this in the Safari preference 'Extensions' tab. Thanks! |
Don't worry I wanted to add it there in the first place but it seems not possible anymore with the new Safari Extension API |
Got it. Got slightly confused since my old extensions previously installed in Safari still shows this. |
There seems to be a bug where it reappears. It seems to work on the very first page load, but refreshing the youtube video page seems to show the button again. Should I make a new issue for this? |
Did you disable it and then it reappears? |
Yes. I've even tried uninstalling it and deleting all the containers. |
This should be considered as a bug and is noted in issue #15 |
Hi, am using JW Player (flash) on streamtvbox website, but the button doesn't seem to appear to be able to click it, I've tried pausing and playing, nothing seems to work? Any help would be greatly appreciated, thanks. |
Flash is not supported by PiP mode in Sierra so this is not possible. Also this is not the right issue for it so I'll clean this up in a bit |
Maybe outdated, but unfortunately some websites still use Silverlight (by Microsoft). I'm just wondering if it would be possible to see PiPifier supporting those videos in some future update? PS: Just downloaded it from the AppStore and I'm quite happy with it. Thanks! |
@WillyH93 unfortunately PiP on Sierra supports only HTML5 videos. So Silverlight can't be supported at the moment |
Would be awesome to add Udemy. |
@WilliamBlais As far as I'm aware, it already supports Udemy, for me the button is on the bottom left next to play |
What about Facebook? |
I was wondering about support for RTP since that uses the HTML5 Radiant Media Player. |
So, it's not strictly a video player... but would it be possible to add support for Tumblr TV. I like to have GIFs playing in the background while I work. Would be neat to have it in PiP. |
To add to the wishlist: THEOPLayer would be nice. It is used by vualto, .. to stream NBC, CNN, Vrt (belgian public broadcasting), ... |
2d783e0 adds the possibility to enable custom PiP in the video player of popular pages. This option is enabled by default since I find the inline PiP much more useful.
One major advantage is that this doesn't require any other interaction that you would need for autoplaying video players.
At the moment this feature only supports Youtube.
Here is an updating list of video players that are supported/deprecated(because they added their own button)/wished:
If you have any player you want to see supported don't hesitate and I add it to the wishlist
The text was updated successfully, but these errors were encountered: