Skip to content

Commit

Permalink
drm/panel: panel-simple: Don't init gpio value at probe
Browse files Browse the repository at this point in the history
When enable display on loader, init gpio would change
gpio status, that would make screen flash.

Change-Id: I4b69a8d3d83c5bef09014c2134abaee6522a7046
Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: Sandy Huang <hjc@rock-chips.com>
Signed-off-by: Guochun Huang <hero.huang@rock-chips.com>
  • Loading branch information
sandy-huang authored and rkhuangtao committed Mar 1, 2024
1 parent 9d969d5 commit f24d59c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/gpu/drm/panel/panel-simple.c
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,8 @@ static int panel_simple_suspend(struct device *dev)
}
}

gpiod_set_value_cansleep(p->reset_gpio, 1);
gpiod_set_value_cansleep(p->enable_gpio, 0);
gpiod_direction_output(p->reset_gpio, 1);
gpiod_direction_output(p->enable_gpio, 0);

panel_simple_regulator_disable(p);

Expand Down Expand Up @@ -630,7 +630,7 @@ static int panel_simple_resume(struct device *dev)
return err;
}

gpiod_set_value_cansleep(p->enable_gpio, 1);
gpiod_direction_output(p->enable_gpio, 1);

if (p->desc->delay.prepare)
panel_simple_msleep(p->desc->delay.prepare);
Expand All @@ -642,12 +642,12 @@ static int panel_simple_resume(struct device *dev)
return 0;
}

gpiod_set_value_cansleep(p->reset_gpio, 1);
gpiod_direction_output(p->reset_gpio, 1);

if (p->desc->delay.reset)
panel_simple_msleep(p->desc->delay.reset);

gpiod_set_value_cansleep(p->reset_gpio, 0);
gpiod_direction_output(p->reset_gpio, 0);

if (p->desc->delay.init)
panel_simple_msleep(p->desc->delay.init);
Expand Down

0 comments on commit f24d59c

Please sign in to comment.