RK3588: add mpp and rkvenc2 nodes

[benhoff]

Description

This ports Collabora's patches from 6.8 to 6.10 for the 580 encoding nodes. This should allow ffmpeg-rockchip to be used with an up to date kernel

How Has This Been Tested?

To be tested using OP5+

Checklist:

Please delete options that are not relevant.

• I have performed a self-review of my own code
• My changes generate no new warnings

[hbiyik]

@benhoff you might want to check below branch.

https://github.com/hbiyik/linux/tree/panthor%2Bmpp%2Brga

Bsp mpp and rga kernel drivers are ported to mainline linux there.

starts at commit d98096a3cab8486905a7db064fb820078c3d35c4 and ends in ad3bc03d168ebdaff8aba161f0b992dc2912391c

[benhoff]

@hbiyik , will your branch run rockchip-ffmpeg?

I just want HW accelerated h264 encoding. Maybe h265 encoding if I'm feeling frisky.

[hbiyik]

will your branch run rockchip-ffmpeg?

yep, i tested that it was working at that time

[amazingfate]

Mpp is a driver from vendor kernel, and I think it is not a good idea to integrate it into mainline kernel by default.
This driver patch is super large and hard to maintain. Is it possible to install the driver as dkms?
And it's also better to use devicetree overlay.

[benhoff]

@amazingfate , I'll open a pr for the device tree overlay tomorrow. I've got one kicking around that I've applied locally.

Makes sense on the dkms bit.

I haven't looked and I can dig into it tomorrow, but do you know off the cuff how that normally gets distributed? I assume not apt.

[EvilOlaf]

Not sure if this is worth the effort overall. 6.10 will probably be abandoned for 6.11.y as soon as 6.12-rc hits which then likely will become new edge for this family. Also 6.10 is not an upstream LTS kernel, so this is kind of riding a dead horse.

[amazingfate]

@amazingfate , I'll open a pr for the device tree overlay tomorrow. I've got one kicking around that I've applied locally.

Makes sense on the dkms bit.

I haven't looked and I can dig into it tomorrow, but do you know off the cuff how that normally gets distributed? I assume not apt.

Dkms has to get packaged to deb. I have pacakged bcmdhd driver at https://github.com/armbian/bcmdhd-dkms, in which deb is packaged at github workflow: https://github.com/armbian/bcmdhd-dkms/blob/main/.github/workflows/release.yml
And in armbian dkms package is installed with extension: https://github.com/armbian/build/blob/main/extensions/bcmdhd.sh

[benhoff]

Not sure if this is worth the effort overall. 6.10 will probably be abandoned for 6.11.y as soon as 6.12-rc hits which then likely will become new edge for this family. Also 6.10 is not an upstream LTS kernel, so this is kind of riding a dead horse.

I have a 6.10 kernel that I'm actively developing with so its easier for me to test locally. However, whatever is worth keeping of this patch (if anything) should be pretty portable to any kernel version.

I just need to burn an updated image on an SD which I haven't in awhile.

[benhoff]

@amazingfate , any value in pulling in the entire driver from @hbiyik 's linux branch into dkms for Armbian?

I must have H264 encoding (and probably decoding) for my own project, so I know I must do something here.

If there's value to Armbian to grab the whole driver it might not be much more additional effort.

Disclaimer, I haven't looked though.

[benhoff]

Device tree overlay in this branch: #7298

I'll explore DKMS packaging as suggested in this thread rather than modifying the kernel.