From 1586fd09e67089a479731d344bec3df0e150a9d7 Mon Sep 17 00:00:00 2001 From: Igor Pecovnik Date: Tue, 13 Aug 2024 09:48:46 +0200 Subject: [PATCH 1/3] Discord annoucement: push only when label "Needs review" is set --- .github/workflows/pr-announce.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-announce.yml b/.github/workflows/pr-announce.yml index 94988e6d0bf5..f2fa26bae24b 100644 --- a/.github/workflows/pr-announce.yml +++ b/.github/workflows/pr-announce.yml @@ -1,13 +1,16 @@ +name: "Announce on Discord" on: pull_request: - types: [ opened ] + types: [ opened, reopened, labeled, review_requested ] branches: [ main ] jobs: - build: - name: "Announce PR on Discord" + Announce: + permissions: + pull-requests: read + runs-on: ubuntu-latest - if: ${{ github.repository_owner == 'Armbian' }} + if: ${{ github.repository_owner == 'Armbian' && contains(github.event.pull_request.labels.*.name, 'Needs review') }} steps: - name: Get repo uses: actions/checkout@v4 From 93ef07b7b47345c32ea0ce9b6717eb1f00d501a8 Mon Sep 17 00:00:00 2001 From: Igor Pecovnik Date: Tue, 13 Aug 2024 19:24:24 +0200 Subject: [PATCH 2/3] Change to label triggering --- .github/workflows/pr-announce.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pr-announce.yml b/.github/workflows/pr-announce.yml index 1e68527af197..158a5e3eec42 100644 --- a/.github/workflows/pr-announce.yml +++ b/.github/workflows/pr-announce.yml @@ -1,8 +1,7 @@ -name: "Announce on Discord" +name: "Announce ready-to-review PR on Discord" on: pull_request: - types: [ opened, reopened, labeled, review_requested ] - branches: [ main ] + types: [ labeled ] jobs: Announce: @@ -10,7 +9,7 @@ jobs: pull-requests: read runs-on: ubuntu-latest - if: ${{ github.repository == 'armbian/build' && contains(github.event.pull_request.labels.*.name, 'Needs review') }} + if: ${{ github.repository == 'armbian/build' && github.event.label.id == '6210849975' }} steps: - name: Get repo uses: actions/checkout@v4 From 93c2a0d80ebcdb59ef4bba8fcd4d0f03804a3f0a Mon Sep 17 00:00:00 2001 From: ColorfulRhino <131405023+ColorfulRhino@users.noreply.github.com> Date: Thu, 15 Aug 2024 22:52:40 +0200 Subject: [PATCH 3/3] actions: Add run-name to `pr-announce` workflow --- .github/workflows/pr-announce.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-announce.yml b/.github/workflows/pr-announce.yml index 158a5e3eec42..6953ba98d567 100644 --- a/.github/workflows/pr-announce.yml +++ b/.github/workflows/pr-announce.yml @@ -1,4 +1,6 @@ -name: "Announce ready-to-review PR on Discord" +name: "Announce PR on Discord for review" +run-name: 'Announce PR #${{ github.event.pull_request.number }} on Discord for review' + on: pull_request: types: [ labeled ]