Discord announcement: push only when label "Needs review" is set

[igorpecovnik]

Description

As tittle said.

How Has This Been Tested?

Need to be tested.

Checklist:

• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[EvilOlaf]

This could trigger the flow to be executed more than once for the same pr. I'd try to avoid that. 1 announce per PR at most. If this is when somebody adds "need review" label its fine too.

[EvilOlaf]

I'd say either revert to initial state which was working and let forks handle resulting errors by themselves (which was the reason why we started bothering with permissions and stuff) or remove completely again since this gets ridiculous for a simple push to chat.

[ColorfulRhino]

@EvilOlaf I had updated this PR a few days ago, it should work as expected now as written in the PR title. I don't quite understand, what's the issue you are talking about in your latest comment?

[EvilOlaf]

Alright, let's see.

[EvilOlaf]

what's the issue you are talking about in your latest comment?

At initial commit it worked but forks would run into problems since the job would fail.
At the first change it did not work anymore for anyone but Igor for unknown reason.
At its current state I don't even remember if it actually works.
So yeah, can probably only get better.

[EvilOlaf]

Doesn't work. secret deployment needs verification. I assume it got lost when it has been switch from repo to org secret.

[ColorfulRhino]

Doesn't work. secret deployment needs verification. I assume it got lost when it has been switch from repo to org secret.

Yeah, I too believe that the remaining issue is an issue with the secret, not with the workflow itself.

Run curl -i -H "Accept: application/json" -H "Content-Type: application/json" -X POST --data \
  curl -i -H "Accept: application/json" -H "Content-Type: application/json" -X POST --data \
  "{\"username\": \"Github\", \"avatar_url\": \"\", \"content\": \"\
  :arrow_heading_up: **Pull request** to [$GITHUB_REPOSITORY](<$GITHUB_SERVER_URL/$GITHUB_REPOSITORY>) by [$GITHUB_ACTOR](<$GITHUB_SERVER_URL/$GITHUB_ACTOR>) - **Please review!** \
  :point_right: [Link](<$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/pull/7112>): *$(git show -s --format=%s)*\"}" 
  shell: /usr/bin/bash -e {0}
curl: no URL specified!

Edit: It may even be the same issue as with the pr-build-artifacts.yml workflow (probably a permission issue). This can be tested if @igorpecovnik adds the "Review needed" label to a PR. If that works, it's likely a permission issue with the secret.