Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firstlogin: quote values if space is legal #6942

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

jkt628
Copy link
Contributor

@jkt628 jkt628 commented Jul 13, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

GitHub issue reference: #6940
Jira reference number AR-2419

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@jkt628 jkt628 requested a review from a team as a code owner July 13, 2024 13:08
@github-actions github-actions bot added size/small PR with less then 50 lines BSP Board Support Packages labels Jul 13, 2024
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorpecovnik
Copy link
Member

Thank you for looking into!

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jul 13, 2024
@amazingfate
Copy link
Contributor

Good job!

@EvilOlaf EvilOlaf merged commit e7b0c3f into armbian:main Jul 14, 2024
11 checks passed
@jkt628 jkt628 deleted the fix/6940 branch July 14, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release BSP Board Support Packages Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

4 participants