Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u-boot: embed armbian artifact version in CONFIG_LOCALVERSION #6898

Merged
merged 1 commit into from
Jul 7, 2024
Merged

u-boot: embed armbian artifact version in CONFIG_LOCALVERSION #6898

merged 1 commit into from
Jul 7, 2024

Conversation

rpardini
Copy link
Member

@rpardini rpardini commented Jul 6, 2024

u-boot: embed armbian artifact version in CONFIG_LOCALVERSION

  • u-boot: embed armbian artifact version in CONFIG_LOCALVERSION
    • we're hacking at it anyway, so why not use it to uniquely identify the exact build

@rpardini
u-boot: embed armbian artifact version in CONFIG_LOCALVERSION
16c200d 
- we're hacking at it anyway, so why not use it to uniquely identify the exact build
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Jul 6, 2024
@rpardini rpardini marked this pull request as ready for review July 6, 2024 23:23
@rpardini rpardini requested a review from a team as a code owner July 6, 2024 23:23
ColorfulRhino
ColorfulRhino approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@ColorfulRhino ColorfulRhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure why not.

Is $artifact_version something like 2024.07 or something else?

@rpardini
Copy link
Member Author

rpardini commented Jul 7, 2024

Is $artifact_version something like 2024.07 or something else?

It includes 2024.07, but also the hashes of all patches/configs/hooks etc thus uniquely identifying the build.

@rpardini rpardini merged commit 4232661 into armbian:main Jul 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColorfulRhino ColorfulRhino ColorfulRhino approved these changes

Assignees
No one assigned
Labels
Framework Framework components size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpardini @ColorfulRhino