Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing two problems related to wireless at firstlogin script #6823

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jun 28, 2024

Description

  • removing network manager dependency. Left over from moving networking into extensions.
  • address errors when wireless networking is still not detected

Jira reference number AR-2390

Documentation summary for feature / change

armbian/documentation#438

How Has This Been Tested?

  • Several images on board without wifi only
  • Tested making wrong wifi password 3x, exits with "Unable to connect to AP"
  • Connecting with correct credentials
  • Choosing to not connect to wireless
  • Tested on NM and systemd networkd

Checklist:

  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from a team as a code owner June 28, 2024 18:29
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines BSP Board Support Packages labels Jun 28, 2024
@igorpecovnik igorpecovnik force-pushed the AR-2390 branch 2 times, most recently from e666155 to ba8dd17 Compare June 28, 2024 18:47
@igorpecovnik igorpecovnik added the Work in progress Unfinished / work in progress label Jun 28, 2024
@igorpecovnik igorpecovnik force-pushed the AR-2390 branch 2 times, most recently from 90eb4e9 to d83e747 Compare June 28, 2024 19:49
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug 08 Milestone: Third quarter release Needs review Seeking for review and removed Work in progress Unfinished / work in progress labels Jun 28, 2024
@amazingfate
Copy link
Contributor

Thanks a lot. I will build noble image and test today.

@amazingfate
Copy link
Contributor

Here is another issue. I'm testing armsom sige5 with rtl8852bs wifi, which has two wifi interfaces: wlan0 and p2p0. At first login armbian can't detect SSIDs so I just press Enter for null ssid and password. After starting desktop I can't connect
wifi because there is file /etc/netplan/30-wifis-dhcp.yaml with following contents:

# Created by Armbian firstlogin script
network:
  wifis:
    p2p0
wlan0:
      dhcp4: yes
      dhcp6: yes
      access-points:
        "":
         password: ""

After deleting this file I can connect wifi.

@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Framework Framework components Patches Patches related to kernel, U-Boot, ... Documentation Documentation changes or additions and removed size/medium PR with more then 50 and less then 250 lines labels Jun 29, 2024
- removing network manager dependancy
- errors when wireless networking is still not detected
@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Jun 29, 2024
@github-actions github-actions bot removed the size/large PR with 250 lines or more label Jun 29, 2024
@ColorfulRhino
Copy link
Collaborator

At first login armbian can't detect SSIDs so I just press Enter for null ssid and password.

Maybe we need to

  1. check if the network can be connected to with the given SSID and password (and only then create the yaml file, otherwise either ask again since user might have a typo, or skip connecting)
  2. check for empty ssid/pw

@EvilOlaf EvilOlaf removed their request for review June 30, 2024 03:51
@EvilOlaf
Copy link
Member

Cannot tell anything here. Never used wifi in first-login and probably never will.

@igorpecovnik
Copy link
Member Author

Maybe we need to

  • if empty it re-cycle, exits after 3 cycles of selecting network
  • also added several checks
  • tested on dodgy wifi and it works as expected
  • done many many tests.

@amazingfate
Copy link
Contributor

Tested with rtl8852bs, I can choose which interface to connect wifi. Nice!

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jun 30, 2024
@igorpecovnik igorpecovnik merged commit 2b494ae into main Jun 30, 2024
10 checks passed
@igorpecovnik igorpecovnik deleted the AR-2390 branch June 30, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release BSP Board Support Packages Bugfix Pull request is fixing a bug Documentation Documentation changes or additions Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

4 participants