Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoPi R6S: Update blobs to fix issue #6726

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

Description

FriendlyElec ships their devices with the latest blobs. Trying to run an Armbian image on this board with the old blobs might cause issues.
@rpardini run into those issues with the NanoPC T6 and fixed it in #6711

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

FriendlyElec ships their devices with the latest blobs. Trying to run an Armbian image on this board with the old blobs might cause issues.
@ColorfulRhino ColorfulRhino requested review from rpardini and efectn and removed request for efectn June 11, 2024 15:49
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... labels Jun 11, 2024
Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and... this v1.16 + v1.45 seems pretty prevalent. We had troubles once when bumping the default version (in rk64_common?) but that was about one specific version that had difficulties in certain conditions, afaik already fixed many versions ago -- so we started with board-specific bumps. Maybe it's time to revisit and lower maintenance (eg, bump the default, remove from boards).

@ColorfulRhino
Copy link
Collaborator Author

ColorfulRhino commented Jun 11, 2024

Maybe it's time to revisit and lower maintenance (eg, bump the default, remove from boards).

Yeah I thought about this too, but then remembered that I read in the past that it might cause some issues in certain edge case scenarios.
I'd be fine with updating the default in the family config. I think trying to avoid all problems regarding to the blobs is impossible, since as we saw now also vendors update their blobs and ship devices with them :) So even relying on old blobs, which is not a good practice anyway imo, would not solve this, even though it might mitigate some other edge case problem.

Also at some point we will probably be able to build U-Boot completely open source without these blobs. I'm sure that will cause a few new issues, but that's just how it is if you want progess 😄
Ship it and fix as we go.

@ColorfulRhino ColorfulRhino merged commit 38c8bfc into armbian:main Jun 11, 2024
7 checks passed
@ColorfulRhino ColorfulRhino deleted the r6s-fix-blobs branch June 11, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants