Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update xapian-apt-index only in case of stable release #6714

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

alexl83
Copy link
Contributor

@alexl83 alexl83 commented Jun 9, 2024

Description

update-apt-xapian-index takes an insane amout of time during buid - compounding over dozens of builds you get a nice overhead in compute-time in the hours range

This PR disables update-apt-xapian-index for unstable releases ( $BETA = yes )

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Built orangepi5-plus desktop with and without BETA=yes, results below
Baseline 1st run ( CLEAN_LEVEL="debs,cache" )
Repeat Build Options [ ./compile.sh opi5plus build BRANCH=edge BUILD_DESKTOP=yes CLEAN_LEVEL=debs,cache DESKTOP_APPGROUPS_SELECTED='browsers chat desktop_tools office remote_desktop' DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base RELEASE=bookworm ]
Runtime [ 14:54 min ]
Baseline 2nd run ( CLEAN_LEVEL="debs" )
Repeat Build Options [ ./compile.sh opi5plus build BRANCH=edge BUILD_DESKTOP=yes CLEAN_LEVEL=debs DESKTOP_APPGROUPS_SELECTED='browsers chat desktop_tools office remote_desktop' DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base RELEASE=bookworm ]
Runtime [ 5:45 min ]

Baseline 3rd run ( CLEAN_LEVEL="debs" BETA="yes")
Repeat Build Options [ ./compile.sh opi5plus build BETA=yes BRANCH=edge BUILD_DESKTOP=yes CLEAN_LEVEL=debs DESKTOP_APPGROUPS_SELECTED='browsers chat desktop_tools office remote_desktop' DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base RELEASE=bookworm ]
Runtime [ 5:04 min ]
Baseline 4th run ( CLEAN_LEVEL="debs,cache" BETA="yes")
Repeat Build Options [ ./compile.sh opi5plus build BETA=yes BRANCH=edge BUILD_DESKTOP=yes CLEAN_LEVEL=debs,cache DESKTOP_APPGROUPS_SELECTED='browsers chat desktop_tools office remote_desktop' DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base RELEASE=bookworm ]
Runtime [ 14:14 min ]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@alexl83 alexl83 requested a review from a team as a code owner June 9, 2024 12:23
@github-actions github-actions bot added the size/small PR with less then 50 lines label Jun 9, 2024
@alexl83 alexl83 changed the title update xapian-index only in case of stable release update xapian-apt-index only in case of stable release Jun 9, 2024
@alexl83 alexl83 force-pushed the optimize_synaptic_caching branch from f7d9b46 to 63b169f Compare June 9, 2024 15:03
@alexl83 alexl83 requested a review from igorpecovnik June 9, 2024 15:20
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jun 9, 2024
@igorpecovnik igorpecovnik merged commit 26345f0 into armbian:main Jun 9, 2024
11 of 13 checks passed
@alexl83 alexl83 deleted the optimize_synaptic_caching branch June 14, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants