Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: remove legacy branch #4769

Merged
merged 1 commit into from
Feb 1, 2023
Merged

meson: remove legacy branch #4769

merged 1 commit into from
Feb 1, 2023

Conversation

hzyitc
Copy link
Member

@hzyitc hzyitc commented Jan 30, 2023

Description

legacy was broken.

Let's drop it since current and edge work well.

How Has This Been Tested?

Unnecessary.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@hzyitc hzyitc requested a review from a team as a code owner January 30, 2023 18:07
@hzyitc hzyitc removed the request for review from a team January 30, 2023 18:07
@rpardini
Copy link
Member

I personally am okay with this, but I don't have any of those boards to say anything...
There's PR pending rework on this: #4643 by @mhoffrog -- that will require rework anyway into hooks/extensions.

@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Jan 31, 2023
@igorpecovnik igorpecovnik merged commit 133c595 into armbian:master Feb 1, 2023
@hzyitc hzyitc deleted the meson-remove-legacy branch February 2, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
Ready to merge Reviewed, tested and ready for merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzyitc @rpardini @igorpecovnik