Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kaslrseed to Rockchip's u-boot #4352

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

Manouchehri
Copy link
Collaborator

Description

Partly resolves #4306.

How Has This Been Tested?

If the kaslrseed command hasn't been compiled in to u-boot, it gracefully skips generating the kASLR

  • Booted on a NanoPi R4S

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Manouchehri
Copy link
Collaborator Author

For this to work, #4311 has to be merged in too.

@igorpecovnik
Copy link
Member

OK, when you are done, label both with "Ready"

@Manouchehri Manouchehri added the Ready to merge Reviewed, tested and ready for merge label Oct 26, 2022
@Manouchehri
Copy link
Collaborator Author

Done, tested and KASLR is working for me.

@igorpecovnik igorpecovnik merged commit 420c118 into armbian:master Oct 26, 2022
@RlndVt
Copy link

RlndVt commented Nov 6, 2023

If the kaslrseed command hasn't been compiled in to u-boot, it gracefully skips generating the kASLR

With gracefully skips, do you mean: "Unknown command ' kaslrseed ' - try 'help'"?

This message is concerning at first glance, can we add a check if we can find kaslrseed first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Reviewed, tested and ready for merge
Development

Successfully merging this pull request may close these issues.

CONFIG_RANDOMIZE_BASE support?
3 participants